From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created
Date: Thu, 10 Sep 2015 10:38:47 -0600 [thread overview]
Message-ID: <55F1B217.9040606@redhat.com> (raw)
In-Reply-To: <55F1AE00.8010608@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On 09/10/2015 10:21 AM, Eric Blake wrote:
> Already in mainline, but I'm wondering...
>
>
>> +++ b/util/error.c
>> @@ -18,12 +18,23 @@ struct Error
>> {
>> char *msg;
>> ErrorClass err_class;
>> + const char *src, *func;
>> + int line;
>> };
>>
>
> Should we also be modifying error_copy() to propagate source information
> into the copy?
Rather than just wondering, I've proposed a patch:
http://thread.gmane.org/gmane.comp.emulators.qemu/361110/focus=361117
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-10 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 13:32 [Qemu-devel] [PULL 0/7] error: On abort, report where the error was created Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 1/7] error: De-duplicate code creating Error objects Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 2/7] error: Make error_setg() a function Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 3/7] qga: Clean up unnecessarily dirty casts Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 4/7] qga/vss-win32: Document the DLL requires non-null errp Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 5/7] error: error_set_errno() is unused, drop Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 6/7] error: Revamp interface documentation Markus Armbruster
2015-09-10 13:32 ` [Qemu-devel] [PULL 7/7] error: On abort, report where the error was created Markus Armbruster
2015-09-10 16:21 ` Eric Blake
2015-09-10 16:38 ` Eric Blake [this message]
2015-09-10 16:00 ` [Qemu-devel] [PULL 0/7] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F1B217.9040606@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.