From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Elwell Subject: Re: [PATCH v5 0/6] bcm2835: auxiliar device support for spi Date: Thu, 10 Sep 2015 18:02:47 +0100 Message-ID: <55F1B7B7.3050604@raspberrypi.org> References: <1441359711-2800-1-git-send-email-kernel@martin.sperl.org> <87h9n4weg8.fsf@eliezer.anholt.net> <55F1A651.5090102@tronnes.org> <8B777380-A2A1-475E-8A1C-942BF28EE160@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Cc: Mark Rutland , devicetree@vger.kernel.org, Ian Campbell , Russell King , Pawel Moll , Stephen Warren , Lee Jones , linux-kernel@vger.kernel.org, Rob Herring , linux-spi@vger.kernel.org, Eric Anholt , Mark Brown , linux-rpi-kernel@lists.infradead.org, Kumar Gala , linux-arm-kernel@lists.infradead.org To: Martin Sperl , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Return-path: In-Reply-To: <8B777380-A2A1-475E-8A1C-942BF28EE160@martin.sperl.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org [ Sending again in plain text ] Noralf pointed me at fixed-factor-clock, and that works in our (downstream) environment: soc: soc { ... uart1: uart@7e215040 { compatible =3D "brcm,bcm2835-aux-uart", "ns16550"; reg =3D <0x7e215040 0x40>; interrupts =3D <1 29>; clocks =3D <&clk_uart1>; reg-shift =3D <2>; no-loopback-test; status =3D "disabled"; }; }; clocks: clocks { ... clk_core: clock@2 { compatible =3D "fixed-clock"; reg =3D <2>; #clock-cells =3D <0>; clock-output-names =3D "core"; clock-frequency =3D <250000000>; }; ... clk_uart1: clock@6 { compatible =3D "fixed-factor-clock"; clocks =3D <&clk_core>; #clock-cells =3D <0>; clock-div =3D <1>; clock-mult =3D <2>; }; }; Phil On 10/09/2015 16:57, Martin Sperl wrote: >> On 10.09.2015, at 17:48, Noralf Tr=F8nnes wrote: >> >> This looks interesting. >> But there's a challenge with the uart1 and the 8250 driver. >> >> Phil Elwell has this to say: >> This means that that UART1 isn't an exact clone of a 8250 UART. >> In a particular, the clock divisor is calculated differently. >> A standard 8250 derives the baud rate as clock/(divisor16), >> whereas the BCM2835 mini UART uses clock/(divisor8). This means >> that if you want to use the standard driver then you need to lie >> about the clock frequency, providing a value is twice the real >> value, in order for a suitable divisor to be calculated. >> >> Ref: https://github.com/raspberrypi/linux/pull/1008#issuecomment-1392346= 07 >> >> So either we need a new uart1 driver or a doubled clock freq. somehow. > Found out the same thing and communicated it to Eric - not = > knowing about the different divider=85 > > Martin On 10/09/2015 16:57, Martin Sperl wrote: >> On 10.09.2015, at 17:48, Noralf Tr=F8nnes wrote: >> >> This looks interesting. >> But there's a challenge with the uart1 and the 8250 driver. >> >> Phil Elwell has this to say: >> This means that that UART1 isn't an exact clone of a 8250 UART. >> In a particular, the clock divisor is calculated differently. >> A standard 8250 derives the baud rate as clock/(divisor16), >> whereas the BCM2835 mini UART uses clock/(divisor8). This means >> that if you want to use the standard driver then you need to lie >> about the clock frequency, providing a value is twice the real >> value, in order for a suitable divisor to be calculated. >> >> Ref: https://github.com/raspberrypi/linux/pull/1008#issuecomment-1392346= 07 >> >> So either we need a new uart1 driver or a doubled clock freq. somehow. > Found out the same thing and communicated it to Eric - not = > knowing about the different divider=85 > > Martin From mboxrd@z Thu Jan 1 00:00:00 1970 From: phil@raspberrypi.org (Phil Elwell) Date: Thu, 10 Sep 2015 18:02:47 +0100 Subject: [PATCH v5 0/6] bcm2835: auxiliar device support for spi In-Reply-To: <8B777380-A2A1-475E-8A1C-942BF28EE160@martin.sperl.org> References: <1441359711-2800-1-git-send-email-kernel@martin.sperl.org> <87h9n4weg8.fsf@eliezer.anholt.net> <55F1A651.5090102@tronnes.org> <8B777380-A2A1-475E-8A1C-942BF28EE160@martin.sperl.org> Message-ID: <55F1B7B7.3050604@raspberrypi.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org [ Sending again in plain text ] Noralf pointed me at fixed-factor-clock, and that works in our (downstream) environment: soc: soc { ... uart1: uart at 7e215040 { compatible = "brcm,bcm2835-aux-uart", "ns16550"; reg = <0x7e215040 0x40>; interrupts = <1 29>; clocks = <&clk_uart1>; reg-shift = <2>; no-loopback-test; status = "disabled"; }; }; clocks: clocks { ... clk_core: clock at 2 { compatible = "fixed-clock"; reg = <2>; #clock-cells = <0>; clock-output-names = "core"; clock-frequency = <250000000>; }; ... clk_uart1: clock at 6 { compatible = "fixed-factor-clock"; clocks = <&clk_core>; #clock-cells = <0>; clock-div = <1>; clock-mult = <2>; }; }; Phil On 10/09/2015 16:57, Martin Sperl wrote: >> On 10.09.2015, at 17:48, Noralf Tr?nnes wrote: >> >> This looks interesting. >> But there's a challenge with the uart1 and the 8250 driver. >> >> Phil Elwell has this to say: >> This means that that UART1 isn't an exact clone of a 8250 UART. >> In a particular, the clock divisor is calculated differently. >> A standard 8250 derives the baud rate as clock/(divisor16), >> whereas the BCM2835 mini UART uses clock/(divisor8). This means >> that if you want to use the standard driver then you need to lie >> about the clock frequency, providing a value is twice the real >> value, in order for a suitable divisor to be calculated. >> >> Ref: https://github.com/raspberrypi/linux/pull/1008#issuecomment-139234607 >> >> So either we need a new uart1 driver or a doubled clock freq. somehow. > Found out the same thing and communicated it to Eric - not > knowing about the different divider? > > Martin On 10/09/2015 16:57, Martin Sperl wrote: >> On 10.09.2015, at 17:48, Noralf Tr?nnes wrote: >> >> This looks interesting. >> But there's a challenge with the uart1 and the 8250 driver. >> >> Phil Elwell has this to say: >> This means that that UART1 isn't an exact clone of a 8250 UART. >> In a particular, the clock divisor is calculated differently. >> A standard 8250 derives the baud rate as clock/(divisor16), >> whereas the BCM2835 mini UART uses clock/(divisor8). This means >> that if you want to use the standard driver then you need to lie >> about the clock frequency, providing a value is twice the real >> value, in order for a suitable divisor to be calculated. >> >> Ref: https://github.com/raspberrypi/linux/pull/1008#issuecomment-139234607 >> >> So either we need a new uart1 driver or a doubled clock freq. somehow. > Found out the same thing and communicated it to Eric - not > knowing about the different divider? > > Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbbIJRJP (ORCPT ); Thu, 10 Sep 2015 13:09:15 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.108]:12217 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbbIJRJK (ORCPT ); Thu, 10 Sep 2015 13:09:10 -0400 X-Greylist: delayed 376 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Sep 2015 13:09:07 EDT X-Env-Sender: phil@raspberrypi.org X-Msg-Ref: server-13.tower-91.messagelabs.com!1441904566!32847032!1 X-Originating-IP: [217.28.140.9] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked Subject: Re: [PATCH v5 0/6] bcm2835: auxiliar device support for spi To: Martin Sperl , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <1441359711-2800-1-git-send-email-kernel@martin.sperl.org> <87h9n4weg8.fsf@eliezer.anholt.net> <55F1A651.5090102@tronnes.org> <8B777380-A2A1-475E-8A1C-942BF28EE160@martin.sperl.org> CC: Eric Anholt , Stephen Warren , Lee Jones , Russell King , Mark Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , , , , , From: Phil Elwell Message-ID: <55F1B7B7.3050604@raspberrypi.org> Date: Thu, 10 Sep 2015 18:02:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <8B777380-A2A1-475E-8A1C-942BF28EE160@martin.sperl.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [217.33.127.174] X-ClientProxiedBy: SEHSTE15FE03.hs20.net (172.18.251.43) To THHSTE15D3BE3.hs20.net (192.168.251.53) X-EXCLAIMER-MD-CONFIG: 266e7a57-cddd-49fd-bdea-19bca6d40303 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Sending again in plain text ] Noralf pointed me at fixed-factor-clock, and that works in our (downstream) environment: soc: soc { ... uart1: uart@7e215040 { compatible = "brcm,bcm2835-aux-uart", "ns16550"; reg = <0x7e215040 0x40>; interrupts = <1 29>; clocks = <&clk_uart1>; reg-shift = <2>; no-loopback-test; status = "disabled"; }; }; clocks: clocks { ... clk_core: clock@2 { compatible = "fixed-clock"; reg = <2>; #clock-cells = <0>; clock-output-names = "core"; clock-frequency = <250000000>; }; ... clk_uart1: clock@6 { compatible = "fixed-factor-clock"; clocks = <&clk_core>; #clock-cells = <0>; clock-div = <1>; clock-mult = <2>; }; }; Phil On 10/09/2015 16:57, Martin Sperl wrote: >> On 10.09.2015, at 17:48, Noralf Trønnes wrote: >> >> This looks interesting. >> But there's a challenge with the uart1 and the 8250 driver. >> >> Phil Elwell has this to say: >> This means that that UART1 isn't an exact clone of a 8250 UART. >> In a particular, the clock divisor is calculated differently. >> A standard 8250 derives the baud rate as clock/(divisor16), >> whereas the BCM2835 mini UART uses clock/(divisor8). This means >> that if you want to use the standard driver then you need to lie >> about the clock frequency, providing a value is twice the real >> value, in order for a suitable divisor to be calculated. >> >> Ref: https://github.com/raspberrypi/linux/pull/1008#issuecomment-139234607 >> >> So either we need a new uart1 driver or a doubled clock freq. somehow. > Found out the same thing and communicated it to Eric - not > knowing about the different divider… > > Martin On 10/09/2015 16:57, Martin Sperl wrote: >> On 10.09.2015, at 17:48, Noralf Trønnes wrote: >> >> This looks interesting. >> But there's a challenge with the uart1 and the 8250 driver. >> >> Phil Elwell has this to say: >> This means that that UART1 isn't an exact clone of a 8250 UART. >> In a particular, the clock divisor is calculated differently. >> A standard 8250 derives the baud rate as clock/(divisor16), >> whereas the BCM2835 mini UART uses clock/(divisor8). This means >> that if you want to use the standard driver then you need to lie >> about the clock frequency, providing a value is twice the real >> value, in order for a suitable divisor to be calculated. >> >> Ref: https://github.com/raspberrypi/linux/pull/1008#issuecomment-139234607 >> >> So either we need a new uart1 driver or a doubled clock freq. somehow. > Found out the same thing and communicated it to Eric - not > knowing about the different divider… > > Martin