From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lists.s-osg.org ([54.187.51.154]:35402 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbIJRf6 (ORCPT ); Thu, 10 Sep 2015 13:35:58 -0400 Subject: Re: [PATCH 1/2] [media] media-device: check before unregister if mdev was registered To: Sakari Ailus , linux-kernel@vger.kernel.org References: <1441890195-11650-1-git-send-email-javier@osg.samsung.com> <1441890195-11650-2-git-send-email-javier@osg.samsung.com> <55F1BAA8.3030107@linux.intel.com> Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org From: Javier Martinez Canillas Message-ID: <55F1BF7A.4000901@osg.samsung.com> Date: Thu, 10 Sep 2015 19:35:54 +0200 MIME-Version: 1.0 In-Reply-To: <55F1BAA8.3030107@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello Sakari, Thanks a lot for your feedback. On 09/10/2015 07:15 PM, Sakari Ailus wrote: > Javier Martinez Canillas wrote: >> Most media functions that unregister, check if the corresponding register >> function succeed before. So these functions can safely be called even if a >> registration was never made or the component as already been unregistered. >> >> Add the same check to media_device_unregister() function for consistency. >> >> This will also allow to split the media_device_register() function in an >> initialization and registration functions without the need to change the >> generic cleanup functions and error code paths for all the media drivers. >> >> Suggested-by: Sakari Ailus >> Signed-off-by: Javier Martinez Canillas >> --- >> >> drivers/media/media-device.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c >> index 1312e93ebd6e..745defb34b33 100644 >> --- a/drivers/media/media-device.c >> +++ b/drivers/media/media-device.c >> @@ -574,6 +574,8 @@ EXPORT_SYMBOL_GPL(__media_device_register); >> * media_device_unregister - unregister a media device >> * @mdev: The media device >> * >> + * If the media device has never been registered this function will >> + * return immediately. > > I'd say "It is safe to call this function on an unregistered (but > initialised) media device.". Up to you. > Ok, I copied that message from media_device_unregister_entity() with s/entity/media device so the kernel doc would be consistent but I don't mind to change to your suggested message since looks more clear to me. > Acked-by: Sakari Ailus > Thanks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America