From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic.
Date: Thu, 10 Sep 2015 12:31:03 -0700 [thread overview]
Message-ID: <55F1DA77.2070606@virtuousgeek.org> (raw)
In-Reply-To: <1440683046-27110-5-git-send-email-maarten.lankhorst@linux.intel.com>
On 08/27/2015 06:44 AM, Maarten Lankhorst wrote:
> + /* on skylake this is done by detaching scalers */
> + if (INTEL_INFO(dev)->gen == 9) {
> + skl_detach_scalers(crtc);
> +
> + if (pipe_config->pch_pfit.enabled)
> + skylake_pfit_enable(crtc);
> + }
> + else if (INTEL_INFO(dev)->gen < 9 &&
> + HAS_PCH_SPLIT(dev)) {
> + if (pipe_config->pch_pfit.enabled)
> + ironlake_pfit_enable(crtc);
> + else if (old_crtc_state->pch_pfit.enabled)
> + ironlake_pfit_disable(crtc, true);
> }
Funky coding style, but otherwise looks ok...
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-10 19:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 13:44 [PATCH v2 0/5] Faster modeset support Maarten Lankhorst
2015-08-27 13:44 ` [PATCH v2 1/5] drm/i915: Set csc coefficients in update_pipe_size Maarten Lankhorst
2015-09-10 19:25 ` Jesse Barnes
2015-09-10 19:27 ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 2/5] drm/i915: Remove references to crtc->active from intel_fbdev.c Maarten Lankhorst
2015-09-10 19:26 ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 3/5] drm/i915: Always try to inherit the initial fb Maarten Lankhorst
2015-09-10 19:26 ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic Maarten Lankhorst
2015-08-27 13:58 ` Ville Syrjälä
2015-08-27 14:06 ` Maarten Lankhorst
2015-08-27 14:33 ` Ville Syrjälä
2015-09-10 19:31 ` Jesse Barnes [this message]
2015-09-14 8:05 ` Daniel Vetter
2015-08-27 13:44 ` [PATCH v2 5/5] drm/i915: skip modeset if compatible for everyone Maarten Lankhorst
2015-08-29 23:57 ` shuang.he
2015-09-10 19:31 ` Jesse Barnes
2015-09-14 8:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F1DA77.2070606@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.