All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [v2][PATCH] xen/vtd/iommu: permit group devices to passthrough in relaxed mode
Date: Fri, 11 Sep 2015 08:56:02 +0800	[thread overview]
Message-ID: <55F226A2.3000404@intel.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D142B07EF5@SHSMSX101.ccr.corp.intel.com>

>> > > Need to have separate warning/error level for relax/strict.
>> > >
>> > > However I don't think this patch is a right fix. So far relax/strict policy
>> > > is per-domain. what about one VM specifies relax while another VM
>> > > specifies strict when each is assigned with a device sharing rmrr
>> > > with the other? In that case it becomes a system-wide security hole.
>> >
>> > The one specifying "strict" won't gets its device assigned (due to
>> > the code above, taking the path that was there already without
>> > the patch), so I don't see the security issue.
>> >
>>
>> Agreed. A VM can't get such device assigned in the first place, so the
>> hypothetical scenario doesn't exist.
>>
>
> Sorry it's a bad example. My actual concern is that we can't count
> on this per-VM relax/strict policy to prevent group devices assigned
> to different VM. In that case it's definitely a security hole since
> one VM may clobber shared RMRR to impact another VM. So right
> example for that scenario is both VMs specified with 'relax'.

What if one of group devices is still owned by Dom0?

Thanks
Tiejun

  reply	other threads:[~2015-09-11  0:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09  1:59 [v2][PATCH] xen/vtd/iommu: permit group devices to passthrough in relaxed mode Tiejun Chen
2015-09-09  6:54 ` Jan Beulich
2015-09-10  1:23   ` Chen, Tiejun
2015-09-10  5:23   ` Tian, Kevin
2015-09-10  5:46     ` Chen, Tiejun
2015-09-10  6:06       ` Tian, Kevin
2015-09-10 11:04         ` Håkon Alstadheim
2015-09-10 11:22           ` Håkon Alstadheim
2015-09-10  8:09     ` Jan Beulich
2015-09-10 10:37       ` Wei Liu
2015-09-10 23:22         ` Tian, Kevin
2015-09-11  0:56           ` Chen, Tiejun [this message]
2015-09-11  0:58             ` Tian, Kevin
2015-09-11  2:20               ` Chen, Tiejun
2015-09-11  2:32                 ` Tian, Kevin
2015-09-11  8:56           ` Jan Beulich
2015-09-11 22:44             ` Tian, Kevin
2015-09-14  6:24               ` Chen, Tiejun
2015-09-14  6:59                 ` Tian, Kevin
2015-09-14 10:48                 ` Jan Beulich
2015-09-15  1:17                   ` Chen, Tiejun
2015-09-15  6:49                     ` Jan Beulich
2015-09-15  9:13                     ` Wei Liu
2015-09-14  6:59 ` Tian, Kevin
2015-09-14  9:11   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F226A2.3000404@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.