From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic
Date: Fri, 11 Sep 2015 10:17:12 +0200
Message-ID: <55F28E08.6060507@redhat.com>
References: <1441941457-23630-1-git-send-email-jasowang@redhat.com>
 <1441941457-23630-2-git-send-email-jasowang@redhat.com>
 <20150911093928.5cb7173c.cornelia.huck@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: gleb@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	mst@redhat.com
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Jason Wang <jasowang@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20150911093928.5cb7173c.cornelia.huck@de.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 11/09/2015 09:39, Cornelia Huck wrote:
> > +static int
> > +kvm_deassign_ioeventfd_idx(struct kvm *kvm, enum kvm_bus bus_idx,
> > +			   struct kvm_ioeventfd *args)
> 
> While this file uses newline before function name quite often, putting
> it on the same line seems more common - don't know which one the
> maintainers prefer.

I prefer it this way if it doesn't make the declaration one line longer,
which seems to be the case here.

Paolo