All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Feng Wu <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v7 11/17] KVM: Define two weak arch callbacks for irq bypass manager
Date: Fri, 11 Sep 2015 12:41:49 +0200	[thread overview]
Message-ID: <55F2AFED.5040306@redhat.com> (raw)
In-Reply-To: <1440492620-15934-12-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>



On 25/08/2015 10:50, Feng Wu wrote:
> Define two weak arch callbacks so that archs that don't need
> them don't need define them.
> 
> Signed-off-by: Feng Wu <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>  virt/kvm/eventfd.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index d7a230f..f3050b9 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -256,6 +256,16 @@ static void irqfd_update(struct kvm *kvm, struct kvm_kernel_irqfd *irqfd)
>  	write_seqcount_end(&irqfd->irq_entry_sc);
>  }
>  
> +void __attribute__((weak)) kvm_arch_irq_bypass_stop(
> +				struct irq_bypass_consumer *cons)
> +{
> +}
> +
> +void __attribute__((weak)) kvm_arch_irq_bypass_start(
> +				struct irq_bypass_consumer *cons)
> +{
> +}
> +
>  static int
>  kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
>  {
> 

This would belong into the patch that adds CONFIG_KVM_HAVE_IRQ_BYPASS
(and the functions should be under "#ifdef CONFIG_KVM_HAVE_IRQ_BYPASS").

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Feng Wu <feng.wu@intel.com>,
	alex.williamson@redhat.com, joro@8bytes.org, mtosatti@redhat.com
Cc: eric.auger@linaro.org, kvm@vger.kernel.org,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 11/17] KVM: Define two weak arch callbacks for irq bypass manager
Date: Fri, 11 Sep 2015 12:41:49 +0200	[thread overview]
Message-ID: <55F2AFED.5040306@redhat.com> (raw)
In-Reply-To: <1440492620-15934-12-git-send-email-feng.wu@intel.com>



On 25/08/2015 10:50, Feng Wu wrote:
> Define two weak arch callbacks so that archs that don't need
> them don't need define them.
> 
> Signed-off-by: Feng Wu <feng.wu@intel.com>
> ---
>  virt/kvm/eventfd.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index d7a230f..f3050b9 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -256,6 +256,16 @@ static void irqfd_update(struct kvm *kvm, struct kvm_kernel_irqfd *irqfd)
>  	write_seqcount_end(&irqfd->irq_entry_sc);
>  }
>  
> +void __attribute__((weak)) kvm_arch_irq_bypass_stop(
> +				struct irq_bypass_consumer *cons)
> +{
> +}
> +
> +void __attribute__((weak)) kvm_arch_irq_bypass_start(
> +				struct irq_bypass_consumer *cons)
> +{
> +}
> +
>  static int
>  kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
>  {
> 

This would belong into the patch that adds CONFIG_KVM_HAVE_IRQ_BYPASS
(and the functions should be under "#ifdef CONFIG_KVM_HAVE_IRQ_BYPASS").

Paolo

  parent reply	other threads:[~2015-09-11 10:41 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  8:50 [PATCH v7 00/17] Add VT-d Posted-Interrupts support Feng Wu
2015-08-25  8:50 ` Feng Wu
2015-08-25  8:50 ` [PATCH v7 04/17] KVM: Get Posted-Interrupts descriptor address from 'struct kvm_vcpu' Feng Wu
     [not found]   ` <1440492620-15934-5-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:50     ` Paolo Bonzini
2015-09-11 10:50       ` Paolo Bonzini
     [not found] ` <1440492620-15934-1-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-08-25  8:50   ` [PATCH v7 01/17] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-08-25  8:50   ` [PATCH v7 02/17] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-09-11 10:16     ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 03/17] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
2015-08-25  8:50     ` Feng Wu
     [not found]     ` <1440492620-15934-4-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:20       ` Paolo Bonzini
2015-09-11 10:20         ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 05/17] KVM: Add interfaces to control PI outside vmx Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-08-25  8:50   ` [PATCH v7 06/17] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-09-11 10:50     ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 07/17] KVM: make kvm_set_msi_irq() public Feng Wu
2015-08-25  8:50     ` Feng Wu
     [not found]     ` <1440492620-15934-8-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:53       ` Paolo Bonzini
2015-09-11 10:53         ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 08/17] vfio: Select IRQ_BYPASS_MANAGER for vfio PCI devices Feng Wu
2015-08-25  8:50     ` Feng Wu
     [not found]     ` <1440492620-15934-9-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:54       ` Paolo Bonzini
2015-09-11 10:54         ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 09/17] vfio: Register/unregister irq_bypass_producer Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-08-25  8:50   ` [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-08-25 19:57     ` Alex Williamson
     [not found]       ` <1440532664.20355.9.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-26  0:36         ` Wu, Feng
2015-08-26  0:36           ` Wu, Feng
2015-09-11 10:29     ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 11/17] KVM: Define two weak arch callbacks for irq bypass manager Feng Wu
2015-08-25  8:50     ` Feng Wu
     [not found]     ` <1440492620-15934-12-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:41       ` Paolo Bonzini [this message]
2015-09-11 10:41         ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 12/17] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-09-11 10:31     ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 13/17] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-09-11 10:39     ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 14/17] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
2015-08-25  8:50     ` Feng Wu
     [not found]     ` <1440492620-15934-15-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:56       ` Paolo Bonzini
2015-09-11 10:56         ` Paolo Bonzini
2015-08-25  8:50   ` [PATCH v7 15/17] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
2015-08-25  8:50     ` Feng Wu
2015-09-11 11:21     ` Paolo Bonzini
2015-09-14  7:57       ` Wu, Feng
2015-08-25  8:50   ` [PATCH v7 16/17] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
2015-08-25  8:50     ` Feng Wu
     [not found]     ` <1440492620-15934-17-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:59       ` Paolo Bonzini
2015-09-11 10:59         ` Paolo Bonzini
2015-08-25  8:50 ` [PATCH v7 17/17] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-09-11 11:05   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F2AFED.5040306@redhat.com \
    --to=pbonzini-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.