From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6273452783122305070==" MIME-Version: 1.0 From: Richard PALO Subject: Re: [Devel] PATCH proposal removing use of strtoul in events/evgpeinit.c Date: Fri, 11 Sep 2015 12:56:33 +0200 Message-ID: <55F2B361.6060404@netbsd.org> In-Reply-To: 94F2FBAB4432B54E8AACC7DFDE6C92E37D343FA1@ORSMSX112.amr.corp.intel.com List-ID: To: devel@acpica.org --===============6273452783122305070== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Le 09/09/15 20:01, Moore, Robert a =C3=A9crit : > I've got a better question: > = >> which is to say that strtoul, strictly speaking is unavailable in the >> Solaris kernel (excepting kmdb). > = > Why not? > = > Given numerous other build problems involving ACPI_DISASSEMLER in _KERNEL, = those are disabled for now (issues with MpSave* which I believe other platforms are experiencing as we= ll, just like the visibility of AcpiUtConvertStringToUuid). I believe other uses of strtoul may tend to be concentrated there... As to the history of decisions involving ddi_strtoul/strtoul, a veteran sun= kernel developer needs to be asked... In any event, currently the wrapper around ddi_strtoul seems reasonable eno= ugh. BTW, have things been linted recently (we use sun studio lint)? = I had to add the following to acsolaris.h > #ifdef __SUNPRO_C > #pragma error_messages(off, E_STATIC_UNUSED) > #pragma error_messages(off, E_FUNC_ARG_UNUSED) > #pragma error_messages(off, E_END_OF_LOOP_CODE_NOT_REACHED) > #pragma error_messages(off, E_FUNC_RET_MAYBE_IGNORED2) > #endif not to mention kludge needed when linting global crosschecks in the illumos= gate, for the later > "/home/richard/src/illumos-gate/usr/src/common/acpica/components/dispatch= er/dsobject.c", line 351: warning: function returns value which is sometime= s ignored: memcpy (E_FUNC_RET_MAYBE_IGNORED2) > "/home/richard/src/illumos-gate/usr/src/common/acpica/components/dispatch= er/dsutils.c", line 608: warning: function returns value which is sometimes= ignored: strncpy (E_FUNC_RET_MAYBE_IGNORED2) > "/home/richard/src/illumos-gate/usr/src/common/acpica/components/executer= /exmisc.c", line 370: warning: function returns value which is sometimes ig= nored: strcpy (E_FUNC_RET_MAYBE_IGNORED2) > "/home/richard/src/illumos-gate/usr/src/common/acpica/components/executer= /exnames.c", line 224: warning: function returns value which is sometimes i= gnored: strcat (E_FUNC_RET_MAYBE_IGNORED2) -- = Richard PALO --===============6273452783122305070==--