From: "Andreas Färber" <afaerber@suse.de>
To: shannon.zhao@linaro.org, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
peter.huangpeng@huawei.com, zhaoshenglong@huawei.com,
christoffer.dall@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()
Date: Fri, 11 Sep 2015 15:39:03 +0200 [thread overview]
Message-ID: <55F2D977.4040902@suse.de> (raw)
In-Reply-To: <55F28EFE.6030109@msgid.tls.msk.ru>
Am 11.09.2015 um 10:21 schrieb Michael Tokarev:
> 12.05.2015 05:25, shannon.zhao@linaro.org wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
> []
>> - DEFINE_PROP_END_OF_LIST()
>> + DEFINE_PROP_END_OF_LIST(),
> []
>
> I don't see a reason doing this.
Yeah, "end of list" means nothing follows after, so no comma needed.
HTE,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: shannon.zhao@linaro.org, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
peter.huangpeng@huawei.com, zhaoshenglong@huawei.com,
christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()
Date: Fri, 11 Sep 2015 15:39:03 +0200 [thread overview]
Message-ID: <55F2D977.4040902@suse.de> (raw)
In-Reply-To: <55F28EFE.6030109@msgid.tls.msk.ru>
Am 11.09.2015 um 10:21 schrieb Michael Tokarev:
> 12.05.2015 05:25, shannon.zhao@linaro.org wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
> []
>> - DEFINE_PROP_END_OF_LIST()
>> + DEFINE_PROP_END_OF_LIST(),
> []
>
> I don't see a reason doing this.
Yeah, "end of list" means nothing follows after, so no comma needed.
HTE,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-09-11 13:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 2:25 [Qemu-trivial] [PATCH 0/6] Blank property cleanup shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-05-12 2:25 ` [Qemu-trivial] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-05-12 7:35 ` [Qemu-trivial] " Cornelia Huck
2015-05-12 7:35 ` Cornelia Huck
2015-05-12 7:52 ` [Qemu-trivial] " Peter Maydell
2015-05-12 7:52 ` [Qemu-devel] " Peter Maydell
2015-05-12 7:55 ` [Qemu-trivial] " Shannon Zhao
2015-05-12 7:55 ` [Qemu-devel] " Shannon Zhao
2015-09-11 8:00 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 8:00 ` [Qemu-devel] " Michael Tokarev
2015-09-11 13:41 ` [Qemu-trivial] " Andreas Färber
2015-09-11 13:41 ` Andreas Färber
2015-05-12 2:25 ` [Qemu-trivial] [PATCH 2/6] hw/virtio/virtio-balloon: " shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-09-11 8:01 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 8:01 ` [Qemu-devel] " Michael Tokarev
2015-05-12 2:25 ` [Qemu-trivial] [PATCH 3/6] hw/virtio/virtio-pci: " shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-09-11 8:02 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 8:02 ` [Qemu-devel] " Michael Tokarev
2015-05-12 2:25 ` [Qemu-trivial] [PATCH 4/6] hw/gpio/zaurus: " shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-09-11 8:04 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 8:04 ` [Qemu-devel] " Michael Tokarev
2015-05-12 2:25 ` [Qemu-trivial] [PATCH 5/6] hw/arm/spitz: " shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-09-11 8:04 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 8:04 ` [Qemu-devel] " Michael Tokarev
2015-05-12 2:25 ` [Qemu-trivial] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST() shannon.zhao
2015-05-12 2:25 ` [Qemu-devel] " shannon.zhao
2015-05-12 6:59 ` [Qemu-trivial] " Peter Maydell
2015-05-12 6:59 ` [Qemu-devel] " Peter Maydell
2015-05-12 7:11 ` [Qemu-trivial] " Shannon Zhao
2015-05-12 7:11 ` [Qemu-devel] " Shannon Zhao
2015-09-11 8:21 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 8:21 ` [Qemu-devel] " Michael Tokarev
2015-09-11 13:39 ` Andreas Färber [this message]
2015-09-11 13:39 ` Andreas Färber
2015-05-20 1:06 ` [Qemu-trivial] [PATCH 0/6] Blank property cleanup Shannon Zhao
2015-05-20 1:06 ` [Qemu-devel] " Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F2D977.4040902@suse.de \
--to=afaerber@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=hangaohuai@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.