All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: Maninder Singh <maninder1.s@samsung.com>, <yocto@yoctoproject.org>
Cc: pankaj.m@samsung.com
Subject: Re: [prelink-cross][PATCH 1/1] rtld: remove if check before free
Date: Fri, 11 Sep 2015 09:10:57 -0500	[thread overview]
Message-ID: <55F2E0F1.8040609@windriver.com> (raw)
In-Reply-To: <1435062512-34808-1-git-send-email-maninder1.s@samsung.com>

I did not merge this patch.  While it's not strictly necessary to get for
allocation before free.  It's also not a bad practice to do so.

--Mark

On 6/23/15 7:28 AM, Maninder Singh wrote:
> No need of explicit NULL check before free
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
>  trunk/src/rtld/rtld.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/trunk/src/rtld/rtld.c b/trunk/src/rtld/rtld.c
> index 35dfde7..3ed1db3 100644
> --- a/trunk/src/rtld/rtld.c
> +++ b/trunk/src/rtld/rtld.c
> @@ -1270,7 +1270,6 @@ process_one_dso (DSO *dso, int host_paths)
>  		       (uint32_t) l->l_map_start);
>  	}
>  
> -      if (filename)
>  	free (filename);
>  
>        cur_dso_ent = cur_dso_ent->next;
> 



      reply	other threads:[~2015-09-11 14:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 12:28 [prelink-cross][PATCH 1/1] rtld: remove if check before free Maninder Singh
2015-09-11 14:10 ` Mark Hatle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F2E0F1.8040609@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=maninder1.s@samsung.com \
    --cc=pankaj.m@samsung.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.