From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:45855 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbbIKPYQ (ORCPT ); Fri, 11 Sep 2015 11:24:16 -0400 Message-ID: <55F2F1D9.9010908@xs4all.nl> Date: Fri, 11 Sep 2015 17:23:05 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Mauro Carvalho Chehab , Linux Media Mailing List Subject: Re: [PATCH 09/18] [media] media-entity: enforce check of interface and links creation References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/06/2015 07:30 PM, Mauro Carvalho Chehab wrote: > Drivers should check if interfaces and interface links were > created. Add a must_check for them. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index 3d389f142a1d..62f882d872b1 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -370,14 +370,16 @@ __must_check int media_entity_pipeline_start(struct media_entity *entity, > struct media_pipeline *pipe); > void media_entity_pipeline_stop(struct media_entity *entity); > > -struct media_intf_devnode *media_devnode_create(struct media_device *mdev, > - u32 type, u32 flags, > - u32 major, u32 minor, > - gfp_t gfp_flags); > +struct media_intf_devnode * > +__must_check media_devnode_create(struct media_device *mdev, > + u32 type, u32 flags, > + u32 major, u32 minor, > + gfp_t gfp_flags); > void media_devnode_remove(struct media_intf_devnode *devnode); > -struct media_link *media_create_intf_link(struct media_entity *entity, > - struct media_interface *intf, > - u32 flags); > +struct media_link * > +__must_check media_create_intf_link(struct media_entity *entity, > + struct media_interface *intf, > + u32 flags); > void media_remove_intf_link(struct media_link *link); > void __media_remove_intf_links(struct media_interface *intf); > void media_remove_intf_links(struct media_interface *intf); >