From: Josef Kufner <josef@kufner.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] Pass graph width to pretty formatting, so '%>|' can work properly
Date: Fri, 11 Sep 2015 19:52:36 +0200 [thread overview]
Message-ID: <55F314E4.40408@kufner.cz> (raw)
In-Reply-To: <xmqq1te428xl.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
Ok, there are the two tests (see the second e-mail). It should cover two
cases where something may go wrong.
Junio C Hamano wrote, on 11.9.2015 18:54:
> This "feels" correct ;-), but let me summon Duy who did the %><
> padding at around a5752342 (pretty: support padding placeholders, %<
> %> and %><, 2013-04-19) for an extra set of eyes.
>
> Care to add a test or two while at it?
>
> Thanks.
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-09-11 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 13:47 [PATCH] Pass graph width to pretty formatting, so '%>|' can work properly Josef Kufner
2015-09-11 16:54 ` Junio C Hamano
2015-09-11 17:50 ` [PATCH] Add tests for "Pass graph width to pretty formatting, so '%>|' can work properly" Josef Kufner
2015-09-11 19:37 ` Eric Sunshine
2015-09-11 20:19 ` Junio C Hamano
2015-09-11 20:22 ` Josef Kufner
2015-09-11 20:25 ` Josef Kufner
2015-09-11 17:52 ` Josef Kufner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F314E4.40408@kufner.cz \
--to=josef@kufner.cz \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.