From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752308AbbIKSV1 (ORCPT ); Fri, 11 Sep 2015 14:21:27 -0400 Received: from fr-hpida-esg-02.alcatel-lucent.com ([135.245.210.21]:42938 "EHLO smtp-fr.alcatel-lucent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbIKSVZ (ORCPT ); Fri, 11 Sep 2015 14:21:25 -0400 Subject: Re: [PATCH 1/3] lib/kobject_uevent.c: disable broadcast of uevents to other namespaces To: "Eric W. Biederman" References: <51c185b6fa89f0b8e9e7dcaffb3c21c975c84302.1441762578.git.michael.coss@alcatel-lucent.com> <87zj0tyeq3.fsf@x220.int.ebiederm.org> Cc: gregkh@linuxfoundation.org, davem@davemloft.net, linux-kernel@vger.kernel.org, containers@lists.linuxcontainers.org, serge.hallyn@ubuntu.com, stgraber@ubuntu.com From: Michael J Coss X-Enigmail-Draft-Status: N1110 Message-ID: <55F31B99.2020907@alcatel-lucent.com> Date: Fri, 11 Sep 2015 14:21:13 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <87zj0tyeq3.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/2015 8:36 PM, Eric W. Biederman wrote: > "Michael J. Coss" writes: > >> Restrict sending uevents to only those listeners operating in the same >> network namespace as the system init process. This is the first step >> toward allowing policy control of the forwarding of events to other >> namespaces in userspace. > This limitation whould be better if we only skipped network namespaces > where you are sending spoofed uevents. > > As it sits this has the possibility to break userspace. > > Eric > While I don't necessarily see how this could cause an issue with userspace, I agree that it could be made to work that way and accomplish the same goal and be even more transparent. I would think that it would require some state in the network namespace that would be settable to say enable/disable host uevent broadcasts across this particular netlink socket. ---Michael J Coss