From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZaU3P-00078w-Fc for mharc-grub-devel@gnu.org; Fri, 11 Sep 2015 15:32:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaU3N-00075V-RU for grub-devel@gnu.org; Fri, 11 Sep 2015 15:32:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaU3I-0001R8-TB for grub-devel@gnu.org; Fri, 11 Sep 2015 15:32:09 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:27247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaU3I-0001Qm-L0 for grub-devel@gnu.org; Fri, 11 Sep 2015 15:32:04 -0400 Received: from pps.filterd (m0044010 [127.0.0.1]) by mx0a-00082601.pphosted.com (8.14.5/8.14.5) with SMTP id t8BJ07pO013024; Fri, 11 Sep 2015 12:08:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=uTjkRjlJTUZmoYB3oa5xSR4cBaUyJQVRLRVoYiRRfpE=; b=P1UIcSNjarrDo3VfYGwDyssty70Bz6TO6ILknZ3HkjQ71GqsfZbNQSr9QQIQfw7aP45t L/QA1cEYPf0DUK1F+baGOnG7qaZ5H6btSAH4jxIOby3NVP9nPT/urzKRXC6v2H1mS0iW Yoy1x3sur5PG1p3C4QI8dvEZVihKh9rqtBM= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 1wv3mp0fcu-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 11 Sep 2015 12:08:34 -0700 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.23) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Sep 2015 12:08:32 -0700 Subject: Re: [PATCH] efinet: retransmit if our device is busy To: Andrei Borzenkov , The development of GNU GRUB , References: <1441042475-4916-1-git-send-email-jbacik@fb.com> <55F30604.90202@gmail.com> From: Josef Bacik Message-ID: <55F326AD.1000509@fb.com> Date: Fri, 11 Sep 2015 15:08:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55F30604.90202@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-09-11_08:2015-09-11, 2015-09-11, 1970-01-01 signatures=0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-00082601.pphosted.com id t8BJ07pO013024 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 67.231.145.42 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2015 19:32:10 -0000 On 09/11/2015 12:49 PM, Andrei Borzenkov wrote: > 31.08.2015 20:34, Josef Bacik =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> When I fixed the txbuf handling I ripped out the retransmission code >> since it >> was flooding our network when we had the buggy behavior. Turns out >> this was too >> heavy handed as we can still have transient tx timeouts. So instead >> make sure >> we retry our transmission once per timeout. This way we can deal with >> transient >> transmission problems without flooding the box. This fixes an issue >> we were >> seeing in production. Thanks, >> > > You mean you get timeout in efi send_card_buffer, not higher level? Tha= t > sounds like something steals completion status. Could you send lsefi > after network interface was opened? No i get a timeout at a higher level. We try to transmit, we never get=20 the txbuf thing from getstatus, and we never redo the transmit. This=20 just adds the retransmit back in. Thanks, Josef