Re: [PATCH] crypto: qat - don't check for iommu

[Tadeusz Struk <tadeusz.struk@intel.com>]

On 09/10/2015 11:36 AM, Tadeusz Struk wrote:
> From: John Griffin <john.griffin@intel.com>
> 
> In some cases we don't want iommu to be enabled but still we want enable VFs.
> 
> Signed-off-by: John Griffin <john.griffin@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
>  drivers/crypto/qat/qat_common/adf_sriov.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_common/adf_sriov.c b/drivers/crypto/qat/qat_common/adf_sriov.c
> index 2f77a4a..fb5a53d 100644
> --- a/drivers/crypto/qat/qat_common/adf_sriov.c
> +++ b/drivers/crypto/qat/qat_common/adf_sriov.c
> @@ -245,9 +245,8 @@ int adf_sriov_configure(struct pci_dev *pdev, int numvfs)
>  	}
>  
>  	if (!iommu_present(&pci_bus_type)) {
> -		dev_err(&pdev->dev,
> -			"IOMMU must be enabled for SR-IOV to work\n");
> -		return -EINVAL;
> +		dev_warn(&pdev->dev,
> +			"IOMMU should be enabled for SR-IOV to work correctly\n");
>  	}
>  
>  	if (accel_dev->pf.vf_info) {
> 
Again after checkpatch fixes.

---8<---
From: John Griffin <john.griffin@intel.com>

In some cases we don't want iommu to be enabled but still we want to enable VFs.

Signed-off-by: John Griffin <john.griffin@intel.com>
Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>

diff --git a/drivers/crypto/qat/qat_common/adf_sriov.c b/drivers/crypto/qat/qat_common/adf_sriov.c
index 2f77a4a..1117a8b 100644
--- a/drivers/crypto/qat/qat_common/adf_sriov.c
+++ b/drivers/crypto/qat/qat_common/adf_sriov.c
@@ -244,11 +244,8 @@ int adf_sriov_configure(struct pci_dev *pdev, int numvfs)
 		return -EFAULT;
 	}
 
-	if (!iommu_present(&pci_bus_type)) {
-		dev_err(&pdev->dev,
-			"IOMMU must be enabled for SR-IOV to work\n");
-		return -EINVAL;
-	}
+	if (!iommu_present(&pci_bus_type))
+		dev_warn(&pdev->dev, "IOMMU should be enabled for SR-IOV to work correctly\n");
 
 	if (accel_dev->pf.vf_info) {
 		dev_info(&pdev->dev, "Already enabled for this device\n");