From: Richard Henderson <rth@twiddle.net>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] target-i386: Don't try to enable unsupported TCG features by default
Date: Fri, 11 Sep 2015 12:32:35 -0700 [thread overview]
Message-ID: <55F32C53.8050606@twiddle.net> (raw)
In-Reply-To: <1441999509-26881-1-git-send-email-ehabkost@redhat.com>
On 09/11/2015 12:25 PM, Eduardo Habkost wrote:
> This series makes QEMU stop trying to enable an unsupported feature by default
> in TCG mode, avoiding the warnings shown by the (now enabled by default)
> "check" mode.
>
> To do that, I cchanged the kvm_default_features code to be based on QOM
> properties, and added a new "type" field to allow per-CPU-model KVM defaults to
> be specified.
>
> Before this series:
>
> $ qemu-system-x86_64 -S
> warning: TCG doesn't support requested feature: CPUID.01H:EDX.de [bit 2]
> warning: TCG doesn't support requested feature: CPUID.80000001H:EDX [bit 2]
>
> After this series:
>
> $ ./x86_64-softmmu/qemu-system-x86_64 -S
> [no warning output]
Wouldn't it be easier simply to implement this bit?
It seems like we're simply creating a compatibility mess otherwise.
r~
next prev parent reply other threads:[~2015-09-11 19:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 19:25 [Qemu-devel] [PATCH 0/4] target-i386: Don't try to enable unsupported TCG features by default Eduardo Habkost
2015-09-11 19:25 ` [Qemu-devel] [PATCH 1/4] target-i386: Expand PPRO_FEATURES on qemu64/qemu32 definitions Eduardo Habkost
2015-09-11 19:25 ` [Qemu-devel] [PATCH 2/4] target-i386: Convert kvm_default_*features to property/value pairs Eduardo Habkost
2015-09-14 8:32 ` Paolo Bonzini
2015-09-18 18:06 ` Eduardo Habkost
2015-09-11 19:25 ` [Qemu-devel] [PATCH 3/4] target-i386: Add optional class name to kvm_default_props Eduardo Habkost
2015-09-11 19:25 ` [Qemu-devel] [PATCH 4/4] target-i386: Disable DE on qemu64 & qemu32 on TCG Eduardo Habkost
2015-09-11 19:32 ` Richard Henderson [this message]
2015-09-11 19:58 ` [Qemu-devel] [PATCH 0/4] target-i386: Don't try to enable unsupported TCG features by default Eduardo Habkost
2015-09-12 21:03 ` Paolo Bonzini
2015-09-14 14:56 ` Eduardo Habkost
2015-09-14 17:21 ` Richard Henderson
2015-09-14 17:23 ` Paolo Bonzini
2015-09-14 17:31 ` Richard Henderson
2015-09-14 20:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F32C53.8050606@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.