From: Or Gerlitz <ogerlitz@mellanox.com>
To: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Cc: <netdev@vger.kernel.org>,
John Fastabend <john.r.fastabend@intel.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] net-sysfs: get_netdev_queue_index() cleanup
Date: Sun, 13 Sep 2015 08:46:26 +0300 [thread overview]
Message-ID: <55F50DB2.4080009@mellanox.com> (raw)
In-Reply-To: <1442002119-15823-1-git-send-email-cascardo@redhat.com>
On 9/11/2015 11:08 PM, Thadeu Lima de Souza Cascardo wrote:
> Redo commit ed1acc8cd8c22efa919da8d300bab646e01c2dce.
>
> Commit 822b3b2ebfff8e9b3d006086c527738a7ca00cd0 ("net: Add max rate tx queue
> attribute") moved get_netdev_queue_index around, but kept the old version.
> Probably because of a reuse of the original patch from before Eric's change to
> that function.
>
> Remove one inline keyword, and no need for a loop to find
> an index into a table.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Fixes: 822b3b2ebfff8e9b3d006086c527738a7ca00cd0
Please use here a --abbrev=12 generated short log e.g
Fixes: 22b3b2ebfff ('net: Add max rate tx queue attribute')
> Cc: Or Gerlitz <ogerlitz@mellanox.com>
remove the Cc: line for me and add this one (hate to see myself
mentioned twice here...)
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Good catch!
prev parent reply other threads:[~2015-09-13 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 20:08 [PATCH] net-sysfs: get_netdev_queue_index() cleanup Thadeu Lima de Souza Cascardo
2015-09-11 20:20 ` John Fastabend
2015-09-13 5:46 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F50DB2.4080009@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=cascardo@redhat.com \
--cc=edumazet@google.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.