All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cyril B." <cbay@excellency.fr>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org
Subject: Re: automount subprocesses accumulate
Date: Sun, 13 Sep 2015 13:20:46 +0200	[thread overview]
Message-ID: <55F55C0E.3010806@excellency.fr> (raw)
In-Reply-To: <1442142599.2902.13.camel@themaw.net>

Ian Kent wrote:
> On Fri, 2015-09-11 at 17:14 +0200, Cyril B. wrote:
>> >  Hello Ian,
>> >
>> >  Thanks for the quick response. I was able to reliably reproduce the
>> >  deadlock on a test server with a test script that triggers many
>> >  simultaneous mounts. On this setup /home is replaced with /mnt.
>
> Yes, it's a puzzle.
>
> The default.c module looks like there's no possibility of a deadlock.
> It's fairly simple and there is no place where the mutex isn't released
> before return and there are no other calls are made that could take
> other locks that could introduce a deadlock.
>
> It occurred to me that the call to force_standard_program_map_env() is
> out probably out of order.
>
> It's made after the fork() that's used to exec the program map code.
>
> I think the child is seeing the state of the mutex at the time of the
> fork and if the mutex was locked at that time the child process will
> never see it unlocked since the forked process copy will not see that
> change.
>
> That's just a guess, so let me put together a patch for you to try.
> Are you in a position to be able to apply and build autofs to test?

Sure, I can test as much as I want. I guess I could probably even setup 
a test VM that reproduces the issue and give you root credentials if it 
helps.

-- 
Cyril B.
--
To unsubscribe from this list: send the line "unsubscribe autofs" in

  reply	other threads:[~2015-09-13 11:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 14:43 automount subprocesses accumulate Cyril B.
2015-09-11  5:34 ` Ian Kent
2015-09-11 15:14   ` Cyril B.
2015-09-13 11:09     ` Ian Kent
2015-09-13 11:20       ` Cyril B. [this message]
2015-09-13 11:52         ` Ian Kent
2015-09-13 12:05           ` Cyril B.
2015-09-13 16:53             ` Cyril B.
2015-09-14  1:30             ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F55C0E.3010806@excellency.fr \
    --to=cbay@excellency.fr \
    --cc=autofs@vger.kernel.org \
    --cc=raven@themaw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.