From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Gerhard Bertelsmann <info@gerhard-bertelsmann.de>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-can@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-can-owner@vger.kernel.org
Subject: Re: [linux-sunxi] [PATCH v5 2/2] can: Allwinner A10/A20 CAN Controller support - controller code
Date: Sun, 13 Sep 2015 15:49:05 +0200 [thread overview]
Message-ID: <55F57ED1.7050906@pengutronix.de> (raw)
In-Reply-To: <f8eea0f544eb6367142bbc1c2ab35964@mail.rdts.de>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On 09/13/2015 03:42 PM, Gerhard Bertelsmann wrote:
>> > Even if it does start, it is really confusing. Please move the
>> > clk_prepare_enable in the open function.
>> >
> That was my first approach. IMHO it's useful to enable/disable
> according to the state of the CAN interface to save power.
The open() function is perfectly right, enabling the clock in the probe
function keeps the clock powered even if the CAN controller is not used.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2015-09-13 13:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 11:43 [PATCH v5 0/2] can: Allwinner A10/A20 CAN Controller support - summary Gerhard Bertelsmann
2015-09-13 11:43 ` [PATCH v5 1/2] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings Gerhard Bertelsmann
[not found] ` <1442144632-4541-2-git-send-email-info-La43T0Mi4bH5xCKuJOYmCvaTkwRoYoCU@public.gmane.org>
2015-09-13 12:25 ` Maxime Ripard
2015-09-13 11:43 ` [PATCH v5 2/2] can: Allwinner A10/A20 CAN Controller support - controller code Gerhard Bertelsmann
[not found] ` <1442144632-4541-3-git-send-email-info-La43T0Mi4bH5xCKuJOYmCvaTkwRoYoCU@public.gmane.org>
2015-09-13 12:45 ` Maxime Ripard
2015-09-13 12:50 ` [linux-sunxi] " Marc Kleine-Budde
2015-09-13 13:42 ` Gerhard Bertelsmann
2015-09-13 13:49 ` Marc Kleine-Budde [this message]
[not found] ` <f8eea0f544eb6367142bbc1c2ab35964-6XUBc1GShDsOIzVOb1FTxg@public.gmane.org>
2015-09-13 23:51 ` Julian Calaby
2015-09-14 8:17 ` Maxime Ripard
2015-09-14 12:41 ` Gerhard Bertelsmann
2015-09-14 12:45 ` [linux-sunxi] " Marc Kleine-Budde
[not found] ` <1442144632-4541-1-git-send-email-info-La43T0Mi4bH5xCKuJOYmCvaTkwRoYoCU@public.gmane.org>
2015-09-13 12:22 ` [PATCH v5 0/2] can: Allwinner A10/A20 CAN Controller support - summary Maxime Ripard
2015-09-13 12:57 ` [linux-sunxi] " Marc Kleine-Budde
2015-09-13 13:42 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F57ED1.7050906@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=info@gerhard-bertelsmann.de \
--cc=linux-can-owner@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.