[LTP] settimeofday01:TFAIL in Kernel 4.2.0

[Takeshi Misawa <jeantsuru@icloud.com>]

This is a my first mail to LTP mailing list.

I'm testing Linux Kernel 4.2.0 by LTP. I saw a following Error.
-----
settimeofday01    1  TFAIL  :  settimeofday01.c:98: Error Setting Time, 
errno=22
settimeofday01    2  TFAIL  :  settimeofday01.c:120: Test condition 1 failed
settimeofday01    3  TPASS  :  Test condition 2 successful
-----

In commit of Linux Kernel:
e1d7ba8735551ed79c7a0463a042353574b96da3 "time: Always make sure 
wall_to_monotonic isn't positive"
add a new check to do_settimeofday64().

This commit said:
"As a result one can't set the CLOCK_REALTIME time prior to (1970 + 
system uptime)."

In settimeofday01 test case, parameter of first settimeofday() is 
100s100μs. A lot of cases, TEST_RETURN is -1.

I'd better to modify settimeofday01 test case.

To meet that requirement, I made following changes.(I have less 
confidence that it is correct...)
-----
diff --git a/testcases/kernel/syscalls/settimeofday/settimeofday01.c 
b/testcases/kernel/syscalls/settimeofday
index b598800..a6894fb 100644
--- a/testcases/kernel/syscalls/settimeofday/settimeofday01.c
+++ b/testcases/kernel/syscalls/settimeofday/settimeofday01.c
@@ -88,9 +88,10 @@ int main(int argc, char **argv)
               int condition_number = 1;
               /* reset tst_count in case we are looping */
               tst_count = 0;
-
-               tp.tv_sec = VAL_SEC;
-               tp.tv_usec = VAL_MSEC;
+
+               gettimeofday(&tp, NULL);
+               tp.tv_sec += VAL_SEC;
+               tp.tv_usec += VAL_MSEC;

               TEST(settimeofday(&tp, NULL));
               if (TEST_RETURN == -1) {
----

Result:
settimeofday01    1  TPASS  :  Test condition 1 successful
settimeofday01    2  TPASS  :  Test condition 2 successful

Thanks.


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list