From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan Date: Mon, 14 Sep 2015 11:02:01 +0800 Message-ID: <55F638A9.1090100@rock-chips.com> References: <1441961698-10516-1-git-send-email-shawn.lin@rock-chips.com> <1441961729-10594-1-git-send-email-shawn.lin@rock-chips.com> <20150914024702.GA19678@xsjsorenbubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150914024702.GA19678@xsjsorenbubuntu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: =?UTF-8?Q?S=c3=b6ren_Brinkmann?= Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ulf Hansson , shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Simek , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mmc@vger.kernel.org 5ZyoIDIwMTUvOS8xNCAxMDo0NywgU8O2cmVuIEJyaW5rbWFubiDlhpnpgZM6Cj4gSGkgU2hhd24s Cj4KPiBPbiBGcmksIDIwMTUtMDktMTEgYXQgMDQ6NTVQTSArMDgwMCwgU2hhd24gTGluIHdyb3Rl Ogo+PiBUaGlzIHBhdGNoIGFkZHMgcGh5cyBhbmQgcGh5LW5hbWVzIGZvciBzZGhjaS1vZi1hcmFz YW4gYXMgb3B0aW9uYWwKPj4gcHJvcGVydGllcywgYW5kIGRldGFpbHMgdGhlIGV4YW1wbGUgYXMg d2VsbC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogU2hhd24gTGluIDxzaGF3bi5saW5Acm9jay1jaGlw cy5jb20+Cj4+IC0tLQo+Pgo+PiAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9t bWMvYXJhc2FuLHNkaGNpLnR4dCB8IDEwICsrKysrKysrLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwg OCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21tYy9hcmFzYW4sc2RoY2kudHh0IGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21tYy9hcmFzYW4sc2RoY2kudHh0Cj4+IGluZGV4 IGRhNTQxYzMuLjAyNjRkNWYgMTAwNjQ0Cj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9tbWMvYXJhc2FuLHNkaGNpLnR4dAo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvbW1jL2FyYXNhbixzZGhjaS50eHQKPj4gQEAgLTEsMTEgKzEsMTIg QEAKPj4gICBEZXZpY2UgVHJlZSBCaW5kaW5ncyBmb3IgdGhlIEFyYXNhbiBTREhDSSBDb250cm9s bGVyCj4+Cj4+IC0gIFRoZSBiaW5kaW5ncyBmb2xsb3cgdGhlIG1tY1sxXSwgY2xvY2tbMl0gYW5k IGludGVycnVwdFszXSBiaW5kaW5ncy4gT25seQo+PiAtICBkZXZpYXRpb25zIGFyZSBkb2N1bWVu dGVkIGhlcmUuCj4+ICsgIFRoZSBiaW5kaW5ncyBmb2xsb3cgdGhlIG1tY1sxXSwgY2xvY2tbMl0s IGludGVycnVwdFszXSBhbmQgcGh5WzRdIGJpbmRpbmdzLgo+PiArICBPbmx5IGRldmlhdGlvbnMg YXJlIGRvY3VtZW50ZWQgaGVyZS4KPj4KPj4gICAgIFsxXSBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvbW1jL21tYy50eHQKPj4gICAgIFsyXSBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvY2xvY2svY2xvY2stYmluZGluZ3MudHh0Cj4+ICAgICBbM10gRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2ludGVycnVwdHMu dHh0Cj4+ICsgIFs0XSBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3BoeS1i aW5kaW5ncy50eHQKPj4KPj4gICBSZXF1aXJlZCBQcm9wZXJ0aWVzOgo+PiAgICAgLSBjb21wYXRp YmxlOiBDb21wYXRpYmlsaXR5IHN0cmluZy4gTXVzdCBiZSAnYXJhc2FuLHNkaGNpLTguOWEnIG9y Cj4+IEBAIC0xNiw2ICsxNyw5IEBAIFJlcXVpcmVkIFByb3BlcnRpZXM6Cj4+ICAgICAtIGludGVy cnVwdHM6IEludGVycnVwdCBzcGVjaWZpZXIKPj4gICAgIC0gaW50ZXJydXB0LXBhcmVudDogUGhh bmRsZSBmb3IgdGhlIGludGVycnVwdCBjb250cm9sbGVyIHRoYXQgc2VydmljZXMKPj4gICAJCSAg ICAgIGludGVycnVwdHMgZm9yIHRoaXMgZGV2aWNlLgo+PiArT3B0aW9uYWwgUHJvcGVydGllczoK Pj4gKyAgLSBwaHlzOiBGcm9tIFBIWSBiaW5kaW5nczogUGhhbmRsZSBmb3IgdGhlIEdlbmVyaWMg UEhZIGZvciBhcmFzYW4uCj4+ICsgIC0gcGh5LW5hbWVzOiAgTVVTVCBiZSAicGh5X2FyYXNhbiIu Cj4KPiBUaGlzIG1pZ2h0IGJlIGEgZHVtYiBxdWVzdGlvbiwgYnV0LCBpcyB0aGUgZXh0ZXJuYWwg cGh5IGFjdHVhbGx5Cj4gb3B0aW9uYWw/IE9yIGlzIGl0IG1hbmRhdG9yeSBmb3IgY2VydGFpbiBp bXBsZW1lbnRhdGlvbnMgb2YgdGhlIElQLgo+IEluIHRoZSBsYXR0ZXIgY2FzZSwgaXQgc2hvdWxk IHByb2JhYmx5IGJlIGEgbWFuZGF0b3J5IHByb3BlcnR5IGRlcGVuZGluZwo+IG9uIHRoZSBjb21w YXRpYmxlIHN0cmluZyBtYXRjaGluZyBhbiBpbXBsZW1lbnRhdGlvbiB0aGF0IHJlcXVpcmVzIGFu Cj4gZXh0ZXJuYWwgcGh5IChhY2NvcmRpbmdseSwgdGhlIGltcGxlbWVudGF0aW9uIG1pZ2h0IGhh dmUgdG8gdHJlYXQgaXQKCiBGcm9tIG15IHNvYyB0ZWFtJ3MgcmVwb25zZSwgdGhlcmUgaXMgbm8g d2F5IHRvIGJ5cGFzcyBjb250cm9sbGVyIHRvIElPIAppZiBubyBwaHkgc3VwcG9ydGVkLiBTbyBp dCBzaG91bGQgYmUgdGhlIGxhdHRlciBjYXNlIHlvdSBtZW50aW9uZWQgZm9yIAphcmFzYW4uc2Ro Y2ktNS4xLgoKVGhhbmtzIGZvciBwb2ludCBvdXQgaXQsIHJlYWxseSBoZWxwZnVsLgoKSSB3aWxs IGZpeCBpdCBpbiB2Mi4KCj4gdGhhdCB3YXkgdG9vKS4KPgo+IAlTw7ZyZW4KPgo+Cj4KCgotLSAK QmVzdCBSZWdhcmRzClNoYXduIExpbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hp cEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754129AbbINDCS (ORCPT ); Sun, 13 Sep 2015 23:02:18 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:38721 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753813AbbINDCQ (ORCPT ); Sun, 13 Sep 2015 23:02:16 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: devicetree@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan To: =?UTF-8?Q?S=c3=b6ren_Brinkmann?= References: <1441961698-10516-1-git-send-email-shawn.lin@rock-chips.com> <1441961729-10594-1-git-send-email-shawn.lin@rock-chips.com> <20150914024702.GA19678@xsjsorenbubuntu> Cc: shawn.lin@rock-chips.com, Michal Simek , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org From: Shawn Lin Message-ID: <55F638A9.1090100@rock-chips.com> Date: Mon, 14 Sep 2015 11:02:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150914024702.GA19678@xsjsorenbubuntu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015/9/14 10:47, Sören Brinkmann 写道: > Hi Shawn, > > On Fri, 2015-09-11 at 04:55PM +0800, Shawn Lin wrote: >> This patch adds phys and phy-names for sdhci-of-arasan as optional >> properties, and details the example as well. >> >> Signed-off-by: Shawn Lin >> --- >> >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> index da541c3..0264d5f 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> @@ -1,11 +1,12 @@ >> Device Tree Bindings for the Arasan SDHCI Controller >> >> - The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only >> - deviations are documented here. >> + The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings. >> + Only deviations are documented here. >> >> [1] Documentation/devicetree/bindings/mmc/mmc.txt >> [2] Documentation/devicetree/bindings/clock/clock-bindings.txt >> [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> + [4] Documentation/devicetree/bindings/phy/phy-bindings.txt >> >> Required Properties: >> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or >> @@ -16,6 +17,9 @@ Required Properties: >> - interrupts: Interrupt specifier >> - interrupt-parent: Phandle for the interrupt controller that services >> interrupts for this device. >> +Optional Properties: >> + - phys: From PHY bindings: Phandle for the Generic PHY for arasan. >> + - phy-names: MUST be "phy_arasan". > > This might be a dumb question, but, is the external phy actually > optional? Or is it mandatory for certain implementations of the IP. > In the latter case, it should probably be a mandatory property depending > on the compatible string matching an implementation that requires an > external phy (accordingly, the implementation might have to treat it From my soc team's reponse, there is no way to bypass controller to IO if no phy supported. So it should be the latter case you mentioned for arasan.sdhci-5.1. Thanks for point out it, really helpful. I will fix it in v2. > that way too). > > Sören > > > -- Best Regards Shawn Lin