From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [v2][PATCH] xen/vtd/iommu: permit group devices to
 passthrough in relaxed mode
Date: Mon, 14 Sep 2015 14:24:57 +0800
Message-ID: <55F66839.6030501@intel.com>
References: <1441763998-4937-1-git-send-email-tiejun.chen@intel.com>
	<55EFF3CE02000078000A1150@prv-mh.provo.novell.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D142B05A88@SHSMSX101.ccr.corp.intel.com>
	<55F156E302000078000A18B4@prv-mh.provo.novell.com>
	<20150910103720.GG8496@zion.uk.xensource.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D142B07EF5@SHSMSX101.ccr.corp.intel.com>
	<55F2B34202000078000A201A@prv-mh.provo.novell.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D1568EFA56@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D1568EFA56@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Tian, Kevin" <kevin.tian@intel.com>, Jan Beulich <JBeulich@suse.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Wei Liu <wei.liu2@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

> OK, that explanation is fine to me as long as it's made clear no
> security guarantee once admin uses 'relax' for any domain. Tiejun
> could you resend patch with right warning/error type?
>

Sure, but a little bit makes me confused when I'm trying to address 
this. Actually most messages are same, except for logevel, so I did this 
like,

             printk(XENLOG_G_INFO VTDPREFIX " Assign %04x:%02x:%02x.%u"
                    " with shared RMRR at %"PRIx64" for Dom%d.",
                    seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn),
                    rmrr->base_address, d->domain_id);
             if ( relaxed )
                 printk(XENLOG_G_WARNING VTDPREFIX " It's really risky.");
             else
                 printk(XENLOG_G_ERR VTDPREFIX " So it's disallowed!");
             printk(XENLOG_G_INFO VTDPREFIX "\n");

But looks its not better, so any idea?

Thanks
Tiejun