From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] libxc: remove useless stuff from domain builder Date: Mon, 14 Sep 2015 15:29:57 +0200 Message-ID: <55F6CBD5.3080507@suse.com> References: <1442235249-15198-1-git-send-email-jgross@suse.com> <20150914132312.GG2294@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150914132312.GG2294@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, Ian.Campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/14/2015 03:23 PM, Wei Liu wrote: > On Mon, Sep 14, 2015 at 02:54:09PM +0200, Juergen Gross wrote: >> Remove unused fields from the domain builder and associated functions. >> >> Signed-off-by: Juergen Gross >> --- >> tools/libxc/include/xc_dom.h | 2 -- >> tools/python/xen/lowlevel/xc/xc.c | 8 ++------ >> 2 files changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h >> index 6192fba..5731098 100644 >> --- a/tools/libxc/include/xc_dom.h >> +++ b/tools/libxc/include/xc_dom.h >> @@ -132,7 +132,6 @@ struct xc_dom_image { >> xen_pfn_t total_pages; >> xen_pfn_t p2m_size; /* number of pfns covered by p2m */ >> struct xc_dom_phys *phys_pages; >> - int realmodearea_log; >> #if defined (__arm__) || defined(__aarch64__) >> xen_pfn_t rambank_size[GUEST_RAM_BANKS]; >> #endif >> @@ -157,7 +156,6 @@ struct xc_dom_image { >> >> xc_interface *xch; >> domid_t guest_domid; >> - int8_t vhpt_size_log2; /* for IA64 */ >> int8_t superpages; >> int claim_enabled; /* 0 by default, 1 enables it */ >> int shadow_enabled; >> diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c >> index 9ab53fb..668e875 100644 >> --- a/tools/python/xen/lowlevel/xc/xc.c >> +++ b/tools/python/xen/lowlevel/xc/xc.c >> @@ -463,7 +463,6 @@ static PyObject *pyxc_linux_build(XcObject *self, >> char *image, *ramdisk = NULL, *cmdline = "", *features = NULL; >> int flags = 0; >> int store_evtchn, console_evtchn; >> - int vhpt = 0; >> int superpages = 0; >> unsigned int mem_mb; >> unsigned long store_mfn = 0; >> @@ -477,23 +476,20 @@ static PyObject *pyxc_linux_build(XcObject *self, >> "console_evtchn", "image", >> /* optional */ >> "ramdisk", "cmdline", "flags", >> - "features", "vhpt", "superpages", NULL }; >> + "features", "superpages", NULL }; >> >> if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiis|ssisii", kwd_list, > ^ > This format string needs to be changed, too. It should be "iiis|ssisi", > i.e. one "i" needs to be removed. Indeed. BTW: you've removed two "i"s. It has to be "iiiis|ssisi". Juergen