From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752209AbbINRIq (ORCPT ); Mon, 14 Sep 2015 13:08:46 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33857 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755550AbbINRIo (ORCPT ); Mon, 14 Sep 2015 13:08:44 -0400 Message-ID: <55F6FF17.2070404@oracle.com> Date: Mon, 14 Sep 2015 13:08:39 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eric Dumazet CC: davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atm: deal with setting entry before mkip was called References: <1442245730-31575-1-git-send-email-sasha.levin@oracle.com> <1442249450.14284.5.camel@edumazet-glaptop2.roam.corp.google.com> <55F6FD2A.7080004@oracle.com> <1442250434.14284.6.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1442250434.14284.6.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2015 01:07 PM, Eric Dumazet wrote: > On Mon, 2015-09-14 at 13:00 -0400, Sasha Levin wrote: > >> I've tried to be consistent with a similar check within clip_mkip() and >> clip_setentry(): >> >> if (!vcc->push) >> return -EBADFD; >> >> So calling clip_setentry() before clip_mkip() would also give you -EBADFD. >> > > Okay, but -EBADF is not the same than -EBADFD Doh. Sorry about that. Thanks, Sasha