From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Yang Z Zhang <yang.z.zhang@intel.com>,
Kevin Tian <kevin.tian@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [v2][PATCH] xen/vtd/iommu: permit group devices to passthrough in relaxed mode
Date: Tue, 15 Sep 2015 09:17:07 +0800 [thread overview]
Message-ID: <55F77193.6090303@intel.com> (raw)
In-Reply-To: <55F6C22F02000078000A283A@prv-mh.provo.novell.com>
>> But looks its not better, so any idea?
>
> Did you at least make an attempt to find other examples of where
> we dynamically determine the log level to be used for a message?
> I would assume that if you did, you'd have come to
>
> printk(XENLOG_GUEST "%s" VTDPREFIX
I didn't know this tip on Xen side and its really good.
> " It's %s to assign %04x:%02x:%02x.%u"
> " with shared RMRR at %"PRIx64" for Dom%d.\n",
> relaxed ? XENLOG_WARNING : XENLOG_ERROR,
> relaxed ? "risky" : "disallowed",
> seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn),
> rmrr->base_address, d->domain_id);
>
> pretty naturally.
>
But I noticed my original patch is already merged into staging. So
Wei,
Do you think if we need a small patch to improved this? Maybe you can
squash that if necessary.
Thanks
Tiejun
next prev parent reply other threads:[~2015-09-15 1:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 1:59 [v2][PATCH] xen/vtd/iommu: permit group devices to passthrough in relaxed mode Tiejun Chen
2015-09-09 6:54 ` Jan Beulich
2015-09-10 1:23 ` Chen, Tiejun
2015-09-10 5:23 ` Tian, Kevin
2015-09-10 5:46 ` Chen, Tiejun
2015-09-10 6:06 ` Tian, Kevin
2015-09-10 11:04 ` Håkon Alstadheim
2015-09-10 11:22 ` Håkon Alstadheim
2015-09-10 8:09 ` Jan Beulich
2015-09-10 10:37 ` Wei Liu
2015-09-10 23:22 ` Tian, Kevin
2015-09-11 0:56 ` Chen, Tiejun
2015-09-11 0:58 ` Tian, Kevin
2015-09-11 2:20 ` Chen, Tiejun
2015-09-11 2:32 ` Tian, Kevin
2015-09-11 8:56 ` Jan Beulich
2015-09-11 22:44 ` Tian, Kevin
2015-09-14 6:24 ` Chen, Tiejun
2015-09-14 6:59 ` Tian, Kevin
2015-09-14 10:48 ` Jan Beulich
2015-09-15 1:17 ` Chen, Tiejun [this message]
2015-09-15 6:49 ` Jan Beulich
2015-09-15 9:13 ` Wei Liu
2015-09-14 6:59 ` Tian, Kevin
2015-09-14 9:11 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F77193.6090303@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.