All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: Ivan Petrovic <ivan@ipplus.rs>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: unable to mount multi disk volume with recovery mode
Date: Tue, 15 Sep 2015 09:31:28 +0800	[thread overview]
Message-ID: <55F774F0.2050001@cn.fujitsu.com> (raw)
In-Reply-To: <55F696F9.7090708@oracle.com>

Hi Aand,

Anand Jain wrote on 2015/09/14 17:44 +0800:
>
>
> Hi Qu,
>
>> Unfortunately, single mode means no duplication.
>> And degrade mount only works for RAID level with
>> duplication(DUP,RAID1/5/6/10).
>
> further to the below commit.
>
>   commit 95669976bd7d30ae265db938ecb46a6b7f8cb893
>      Btrfs: don't consider the missing device when allocating new chunks
>
> in case of 2-disk RAID1 mounted with only one good disk, we would create
> Single profile and actually the created single profiles are still
> workable with one disk failed.

Yep, that's the case, and Zhao Lei also found the problem and is still 
working on it internally.

But we are doing it in a more flex amd robust method:

No global missing device number check, but do per-chunk check against 
its stripes at mount time, to ensure it meets the minimum number for 
degradable condition.

So for single/raid0 chunk, they still can't be degraded mounted, if any 
of its stripe is missing.

> And so the proposed patch below will let
> single profile to be mount in this context..
>    [PATCH 23/23] Btrfs: allow -o rw,degraded for single group profile
>
> to recover when missing disk is replaced balance convert can migrate
> single profiles back to RAID1 profile.
>
> Also your explanation for degraded is correct, I am ok to use a new new
> mount option (like auto-reduced-profile ?) if needed / confusing.
Sorry for the confusion I caused.
But for above case, IHMO "degraded" is still the proper term.

For 2 disks, 1 missing, single chunk case, if the chunk is in the good 
disk, it should be a good chunk, no need to be degraded.

>
> Any comments / feedbacks are welcome.

But for the patch, I'd like to do it in the manner I mentioned:
Check every chunk for whether it's possible to be degraded,
other than current whole fs missing device check.

Thanks,
Qu

>
> Thanks, Anand

  parent reply	other threads:[~2015-09-15  1:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 20:45 unable to mount multi disk volume with recovery mode Ivan Petrovic
2015-09-04 21:13 ` Ivan
2015-09-14  6:25 ` Qu Wenruo
2015-09-14  9:44   ` Anand Jain
2015-09-14 23:24     ` Duncan
2015-09-15  1:31     ` Qu Wenruo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-09-04 21:07 Ivan
2015-09-04 21:17 ` Hugo Mills
2015-09-05 10:13   ` Ivan Petrovic
2015-09-05 10:42     ` Hugo Mills
2015-09-07 17:58       ` Chris Murphy
2015-09-07 18:01         ` Chris Murphy
2015-09-07 18:05         ` Hugo Mills

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F774F0.2050001@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=anand.jain@oracle.com \
    --cc=ivan@ipplus.rs \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.