From mboxrd@z Thu Jan 1 00:00:00 1970 From: yangyingliang@huawei.com (Yang Yingliang) Date: Tue, 15 Sep 2015 11:07:33 +0800 Subject: [RFC PATCH v2 1/3] irqchip: GICv3: set non-percpu irqs status with IRQ_MOVE_PCNTXT In-Reply-To: <55F6C2B2.2060808@arm.com> References: <1442222945-10628-1-git-send-email-yangyingliang@huawei.com> <1442222945-10628-2-git-send-email-yangyingliang@huawei.com> <55F6C2B2.2060808@arm.com> Message-ID: <55F78B75.1020105@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/9/14 20:50, Marc Zyngier wrote: > On 14/09/15 10:29, Yang Yingliang wrote: >> Use irq_set_status_flags() helper set irqs status with >> IRQ_MOVE_PCNTXT. So that it can do set affinity when >> calling irq_set_affinity_locked(). >> >> Cc: Jiang Liu >> Cc: Thomas Gleixner >> Cc: Marc Zyngier >> Cc: Mark Rutland >> Cc: Will Deacon >> Cc: Russell King - ARM Linux >> Signed-off-by: Yang Yingliang >> --- >> drivers/irqchip/irq-gic-v3.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c >> index 7deed6e..3d8f400 100644 >> --- a/drivers/irqchip/irq-gic-v3.c >> +++ b/drivers/irqchip/irq-gic-v3.c >> @@ -761,6 +761,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq, >> irq_domain_set_info(d, irq, hw, chip, d->host_data, >> handle_fasteoi_irq, NULL, NULL); >> set_irq_flags(irq, IRQF_VALID | IRQF_PROBE); >> + irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); >> } >> /* LPIs */ >> if (hw >= 8192 && hw < GIC_ID_NR) { >> @@ -769,6 +770,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq, >> irq_domain_set_info(d, irq, hw, chip, d->host_data, >> handle_fasteoi_irq, NULL, NULL); >> set_irq_flags(irq, IRQF_VALID); >> + irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); >> } >> >> return 0; >> > > I'm still not keen on this approach. As far as I can tell, the only > reason you are setting this flag is to be able to use > GENERIC_PENDING_IRQ. irq_set_affinity_locked would work even if you > don't select this config option, because irq_can_move_pcntxt() will > always return true if this is not selected. > > So instead of adding flags that are not required on ARM, why don't you > just make migration.c to compile even when GENERIC_PENDING_IRQ is not > selected? I think this would make a lot more sense. OK, I will try this way. Thanks, Yang > > Thanks, > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752461AbbIODIz (ORCPT ); Mon, 14 Sep 2015 23:08:55 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:65089 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbbIODIy (ORCPT ); Mon, 14 Sep 2015 23:08:54 -0400 Subject: Re: [RFC PATCH v2 1/3] irqchip: GICv3: set non-percpu irqs status with IRQ_MOVE_PCNTXT To: Marc Zyngier , , References: <1442222945-10628-1-git-send-email-yangyingliang@huawei.com> <1442222945-10628-2-git-send-email-yangyingliang@huawei.com> <55F6C2B2.2060808@arm.com> CC: Jiang Liu , Thomas Gleixner , Mark Rutland , Will Deacon , Russell King - ARM Linux From: Yang Yingliang Message-ID: <55F78B75.1020105@huawei.com> Date: Tue, 15 Sep 2015 11:07:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55F6C2B2.2060808@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.219] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.55F78B82.013A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 52d31e13d5375d2f6014c876236a601d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/14 20:50, Marc Zyngier wrote: > On 14/09/15 10:29, Yang Yingliang wrote: >> Use irq_set_status_flags() helper set irqs status with >> IRQ_MOVE_PCNTXT. So that it can do set affinity when >> calling irq_set_affinity_locked(). >> >> Cc: Jiang Liu >> Cc: Thomas Gleixner >> Cc: Marc Zyngier >> Cc: Mark Rutland >> Cc: Will Deacon >> Cc: Russell King - ARM Linux >> Signed-off-by: Yang Yingliang >> --- >> drivers/irqchip/irq-gic-v3.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c >> index 7deed6e..3d8f400 100644 >> --- a/drivers/irqchip/irq-gic-v3.c >> +++ b/drivers/irqchip/irq-gic-v3.c >> @@ -761,6 +761,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq, >> irq_domain_set_info(d, irq, hw, chip, d->host_data, >> handle_fasteoi_irq, NULL, NULL); >> set_irq_flags(irq, IRQF_VALID | IRQF_PROBE); >> + irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); >> } >> /* LPIs */ >> if (hw >= 8192 && hw < GIC_ID_NR) { >> @@ -769,6 +770,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq, >> irq_domain_set_info(d, irq, hw, chip, d->host_data, >> handle_fasteoi_irq, NULL, NULL); >> set_irq_flags(irq, IRQF_VALID); >> + irq_set_status_flags(irq, IRQ_MOVE_PCNTXT); >> } >> >> return 0; >> > > I'm still not keen on this approach. As far as I can tell, the only > reason you are setting this flag is to be able to use > GENERIC_PENDING_IRQ. irq_set_affinity_locked would work even if you > don't select this config option, because irq_can_move_pcntxt() will > always return true if this is not selected. > > So instead of adding flags that are not required on ARM, why don't you > just make migration.c to compile even when GENERIC_PENDING_IRQ is not > selected? I think this would make a lot more sense. OK, I will try this way. Thanks, Yang > > Thanks, > > M. >