All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kang Kai <Kai.Kang@windriver.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] replace inline with static inline for gcc 5.x
Date: Tue, 15 Sep 2015 15:40:25 +0800	[thread overview]
Message-ID: <55F7CB69.3030109@windriver.com> (raw)
In-Reply-To: <1442225461-14559-1-git-send-email-kai.kang@windriver.com>

Please ignore this patch, V2 will be sent.

Sorry for inconvenience.

--Kai

On 2015?09?14? 18:11, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> gcc 5.x defaults to -std=gnu11 instead of -std=gnu89 which causes
> semantics for inline functions changes.
>
> GNU89 inline: Same as C99 extern inline.
>
> So the standalone 'inline' causes error such as:
>
> git/testcases/kernel/syscalls/kill/kill10.c:355: undefined reference to `k_sigaction'
>
> Replace inline with static inline to fix this issue.
>
> Ref:
> https://gcc.gnu.org/gcc-5/porting_to.html
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   testcases/kernel/controllers/libcontrollers/libcontrollers.c | 2 +-
>   testcases/kernel/syscalls/kill/kill10.c                      | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/controllers/libcontrollers/libcontrollers.c b/testcases/kernel/controllers/libcontrollers/libcontrollers.c
> index 844c5bc..75766fc 100644
> --- a/testcases/kernel/controllers/libcontrollers/libcontrollers.c
> +++ b/testcases/kernel/controllers/libcontrollers/libcontrollers.c
> @@ -158,7 +158,7 @@ int read_file(char *filepath, int action, unsigned int *value)
>    * Prints error message and returns -1
>    */
>   
> -inline void error_function(char *msg1, char *msg2)
> +static inline void error_function(char *msg1, char *msg2)
>   {
>   	fprintf(stdout, "ERROR: %s ", msg1);
>   	fprintf(stdout, "%s\n", msg2);
> diff --git a/testcases/kernel/syscalls/kill/kill10.c b/testcases/kernel/syscalls/kill/kill10.c
> index 982d9da..0c51a91 100644
> --- a/testcases/kernel/syscalls/kill/kill10.c
> +++ b/testcases/kernel/syscalls/kill/kill10.c
> @@ -185,7 +185,7 @@ int child_checklist_total = 0;
>   int checklist_cmp(const void *a, const void *b);
>   void checklist_reset(int bit);
>   
> -inline int k_sigaction(int sig, struct sigaction *sa, struct sigaction *osa);
> +static inline int k_sigaction(int sig, struct sigaction *sa, struct sigaction *osa);
>   
>   char *TCID = "kill10";
>   int TST_TOTAL = 1;


-- 
Regards,
Neil | Kai Kang


  reply	other threads:[~2015-09-15  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 10:11 [LTP] [PATCH] replace inline with static inline for gcc 5.x kai.kang
2015-09-15  7:40 ` Kang Kai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-09-16 10:13 [LTP] [PATCH] V2: " kai.kang
2015-09-16 10:13 ` [LTP] [PATCH] " kai.kang
2015-09-16 11:30   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F7CB69.3030109@windriver.com \
    --to=kai.kang@windriver.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.