From: Jonas Gorski <jogo@openwrt.org>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: broonie@kernel.org, Paul Bolle <pebolle@tiscali.nl>,
ziegler@cs.fau.de, linux-kernel@vger.kernel.org
Subject: Re: spi/bcm63xx: unknown CONFIG_BIG_ENDIAN
Date: Tue, 15 Sep 2015 09:40:30 +0200 [thread overview]
Message-ID: <55F7CB6E.1090008@openwrt.org> (raw)
In-Reply-To: <20150915062400.GA9130@i4lab-dhcp156.informatik.uni-erlangen.de>
Hi Valentin,
On 15.09.2015 08:24, Valentin Rothberg wrote:
> Hi Jonas,
>
> your commit 158fcc4e050a ("spi/bcm63xx: replace custom io accessors with
> standard ones") has shown up in today's Linux next tree (i.e.,
> next-20150915).
>
> This commit adds four #ifdef blocks depending on CONFIG_BIG_ENDIAN,
> which is not defined in Kconfig breaking the #ifdef #else conditions.
>
> Is there a patch queued somewhere to add this option to Kconfig?
>
> I found some other candidates like '__BIG_ENDIAN' which is used in other
> drivers, or 'CPU_BIG_ENDIAN' which is defined for mips. Maybe they can
> be used instead.
You are right, and I had fixed this in my V2 patchset from saturday, but
appearently this wasn't fast enough.
Mark? If you can drop patches 2 to 4 that would be easiest for me, but if
you don't do rebases on your for-next branch, then I'll rewrite the
patches to apply on top of the already applied old versions and send a v3.
Jonas
next prev parent reply other threads:[~2015-09-15 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 6:24 spi/bcm63xx: unknown CONFIG_BIG_ENDIAN Valentin Rothberg
2015-09-15 7:40 ` Jonas Gorski [this message]
2015-09-15 8:40 ` Mark Brown
2015-09-15 13:34 ` Jonas Gorski
2015-09-15 14:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F7CB6E.1090008@openwrt.org \
--to=jogo@openwrt.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=valentinrothberg@gmail.com \
--cc=ziegler@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.