All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michel Thierry <michel.thierry@intel.com>
To: "Michał Winiarski" <michal.winiarski@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice.
Date: Tue, 15 Sep 2015 15:01:15 +0100	[thread overview]
Message-ID: <55F824AB.8030408@intel.com> (raw)
In-Reply-To: <1442323816-4712-1-git-send-email-michal.winiarski@intel.com>

On 9/15/2015 2:30 PM, Michał Winiarski wrote:
> It will be initialized just moments later by i915_init_vm. Global and
> aliasing tables are going through different path anyways.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem_gtt.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 8786281..7ff7239 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2129,8 +2129,6 @@ int i915_ppgtt_init(struct drm_device *dev, struct i915_hw_ppgtt *ppgtt)
>   	ret = __hw_ppgtt_init(dev, ppgtt);
>   	if (ret == 0) {
>   		kref_init(&ppgtt->ref);
> -		drm_mm_init(&ppgtt->base.mm, ppgtt->base.start,
> -			    ppgtt->base.total);
>   		i915_init_vm(dev_priv, &ppgtt->base);
>   	}
>
>

Indeed,

Reviewed-by: Michel Thierry <michel.thierry@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-09-15 14:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 13:30 [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice Michał Winiarski
2015-09-15 13:30 ` [PATCH 2/2] drm/i915/gtt: Avoid using addresses in non-canonical form Michał Winiarski
2015-09-15 13:52   ` Chris Wilson
2015-09-15 14:01   ` Michel Thierry
2015-09-15 18:04   ` [PATCH v2 " Michał Winiarski
2015-09-15 20:03     ` Chris Wilson
2015-09-16  9:50     ` [PATCH v3 " Michał Winiarski
2015-09-16  9:57       ` Chris Wilson
2015-09-17 17:17       ` Winiarski, Michal
2015-09-23 12:31         ` Daniel Vetter
2015-09-15 13:39 ` [PATCH 1/2] drm/i915/gtt: Do not initialize drm_mm twice Chris Wilson
2015-09-15 14:01 ` Michel Thierry [this message]
2015-09-15 18:01 ` [PATCH v2 " Michał Winiarski
2015-09-15 20:07   ` Chris Wilson
2015-09-15 20:07   ` Chris Wilson
2015-09-16  9:49   ` [PATCH v3 " Michał Winiarski
2015-09-17 10:59     ` Chris Wilson
2015-09-23  9:51       ` Daniel Vetter
2015-09-23 16:48     ` Imre Deak
2015-09-23 18:55       ` Paulo Zanoni
2015-09-23 20:47         ` Jesse Barnes
2015-09-24 11:20         ` Winiarski, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F824AB.8030408@intel.com \
    --to=michel.thierry@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=michal.winiarski@intel.com \
    --cc=mika.kuoppala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.