From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqpO-0007V5-Dz for qemu-devel@nongnu.org; Tue, 15 Sep 2015 10:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbqpK-0001Qz-5V for qemu-devel@nongnu.org; Tue, 15 Sep 2015 10:03:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqpK-0001Qo-0S for qemu-devel@nongnu.org; Tue, 15 Sep 2015 10:03:18 -0400 References: <1442253477-15422-1-git-send-email-armbru@redhat.com> <1442253477-15422-14-git-send-email-armbru@redhat.com> <20150915105226.GH23145@redhat.com> From: Eric Blake Message-ID: <55F8251E.7090007@redhat.com> Date: Tue, 15 Sep 2015 08:03:10 -0600 MIME-Version: 1.0 In-Reply-To: <20150915105226.GH23145@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kNlkdmWsMKeWrwT6bKPuqqnwVNOBMGMBH" Subject: Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kNlkdmWsMKeWrwT6bKPuqqnwVNOBMGMBH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/15/2015 04:52 AM, Daniel P. Berrange wrote: > On Mon, Sep 14, 2015 at 07:57:44PM +0200, Markus Armbruster wrote: >> Generate just 'FOO' instead of 'struct FOO' when possible. >> >> Drop helper functions that are now unused. >> >> Make pep8 and pylint reasonably happy. >> >> Rename generate_FOO() functions to gen_FOO() for consistency. >> >> Use more consistent and sensible variable names. >> >> Consistently use c_ for mapping keys when their value is a C >> identifier or type. >> >> Simplify gen_enum() and gen_visit_union() >> >> Consistently use single quotes for C text string literals. >=20 > I would have preferred to see one type of change per > patch to make review easier, but this has been through > enough iterations now that no point changing again. I made the same comment back on v3 or v4, and the conclusion from then still holds now - it was less churn to take it as is (since we have clients waiting on the patch to get in) than to worry about splitting and reviewing that the split is sane. :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kNlkdmWsMKeWrwT6bKPuqqnwVNOBMGMBH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+CUeAAoJEKeha0olJ0NqJiwH/1+ElkzYv0BlpIDbZVGYYQvV UgNuVSm7cd5FXNABATTNh6dezaetV2wbqIXVEemGBs4i8jTHeVXHx+hndI39/bpV wUK9JZtGM68rqZ8QyeNRdpR7QtdjHx0vmYSeq+QACXg8RfDSDBAhIK+YaDS8V/yC O9AKXjRjC1cm3Fiq730WXReTf9UVQyeT0exH4cw6d8PaFmMK0CfiWmbjqVcxZVVP TGuK+EJfiaAak3W0phZuQFGelyAmLn6amyIyr0dQ13u66nnYmvYypo7MVEBPMUhX CuoaIsdM+yAXkjKWYndmajuaaO+cxK02zdIycsBVFGJmioq2AElWbsSn/NIq5+A= =wzoi -----END PGP SIGNATURE----- --kNlkdmWsMKeWrwT6bKPuqqnwVNOBMGMBH--