From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 2/8] KVM: x86: add pcommit support Date: Tue, 15 Sep 2015 17:30:35 +0200 Message-ID: <55F8399B.8080101@redhat.com> References: <1441778757-5866-1-git-send-email-guangrong.xiao@linux.intel.com> <1441778757-5866-3-git-send-email-guangrong.xiao@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Xiao Guangrong Return-path: In-Reply-To: <1441778757-5866-3-git-send-email-guangrong.xiao@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/09/2015 08:05, Xiao Guangrong wrote: > + if (!guest_cpuid_has_pcommit(vcpu) && nested) > + vmx->nested.nested_vmx_secondary_ctls_high &= > + ~SECONDARY_EXEC_PCOMMIT; It is legal to set CPUID multiple times, so I think we need if (static_cpu_has(X86_FEATURE_PCOMMIT) && nested) { if (guest_cpuid_has_pcommit(vcpu)) vmx->nested.nested_vmx_secondary_ctls_high |= SECONDARY_EXEC_PCOMMIT; else vmx->nested.nested_vmx_secondary_ctls_high &= ~SECONDARY_EXEC_PCOMMIT; } The INVPCID exit probably should be handled the same way as PCOMMIT; moving both to a new nested_vmx_update_ctls_msrs probably makes sense. This can be done on top of this series. Paolo