All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] openssl: use git formatted patches
Date: Tue, 15 Sep 2015 18:47:27 +0200	[thread overview]
Message-ID: <55F84B9F.8060908@mind.be> (raw)
In-Reply-To: <1442289591-30376-2-git-send-email-ryanbarnett3@gmail.com>

On 15-09-15 05:59, Ryan Barnett wrote:
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Using Git formatted patches makes it easier to adjust the patches when
> needed.
> 
> [Ryan: removed unnecessary patch and updated offsets]
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Ryan Barnett <ryanbarnett3@gmail.com>
> ---
>  ...time-building-manpages-if-we-re-not-going.patch | 27 +++++++++
>  ...odev-Fix-issue-with-signature-generation.patch} | 70 +++++++++++++---------
>  package/openssl/001-do-not-build-docs.patch        | 13 ----
>  3 files changed, 68 insertions(+), 42 deletions(-)
>  create mode 100644 package/openssl/0001-Dont-waste-time-building-manpages-if-we-re-not-going.patch
>  rename package/openssl/{003-cryptodev-Fix-issue-with-signature-generation.patch => 0002-cryptodev-Fix-issue-with-signature-generation.patch} (82%)
>  delete mode 100644 package/openssl/001-do-not-build-docs.patch
> 
> diff --git a/package/openssl/0001-Dont-waste-time-building-manpages-if-we-re-not-going.patch b/package/openssl/0001-Dont-waste-time-building-manpages-if-we-re-not-going.patch
> new file mode 100644
> index 0000000..93e2118
> --- /dev/null
> +++ b/package/openssl/0001-Dont-waste-time-building-manpages-if-we-re-not-going.patch
> @@ -0,0 +1,27 @@
> +From 53980448064b362a58e4ab2aca6f38fec93c07c3 Mon Sep 17 00:00:00 2001
> +From: Mike Frysinger <vapier@gentoo.org>
> +Date: Sat, 16 May 2015 18:53:51 +0200
> +Subject: [PATCH 1/3] Dont waste time building manpages if we're not going to
            ^^^^^^^^^^
 Please generate patches with -N to avoid the 1/3: it's incorrect (there are
only 2 patches) and it causes additional churn when patches are regenerated.

 I also like to add --subject-prefix= to remove the [PATCH] part, which is not
at all useful in this context. But others may disagree.

> + use em.
> +
> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +---
> + Makefile.org | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
[snip]
> diff --git a/package/openssl/001-do-not-build-docs.patch b/package/openssl/001-do-not-build-docs.patch

 If you resend, perhaps you can add -M20% so the rename is detected?

 Regards,
 Arnout

> deleted file mode 100644
> index 135a9d3..0000000
> --- a/package/openssl/001-do-not-build-docs.patch
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Dont waste time building manpages if we're not going to use em.
> -
> ---- openssl/Makefile.org
> -+++ openssl/Makefile.org
> -@@ -792,7 +792,7 @@
> - dist_pem_h:
> - 	(cd crypto/pem; $(MAKE) CC='${CC}' SDIRS='${SDIRS}' CFLAG='${CFLAG}' pem.h; $(MAKE) clean)
> - 
> --install: all install_docs install_sw
> -+install: all install_sw
> - 
> - install_sw:
> - 	@$(PERL) $(TOP)/util/mkdir-p.pl $(INSTALL_PREFIX)$(INSTALLTOP)/bin \
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-09-15 16:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  3:59 [Buildroot] [PATCH 0/2] openssl parallel build Ryan Barnett
2015-09-15  3:59 ` [Buildroot] [PATCH 1/2] openssl: use git formatted patches Ryan Barnett
2015-09-15 16:47   ` Arnout Vandecappelle [this message]
2015-09-15 19:44     ` Ryan Barnett
2015-09-15 20:39       ` Arnout Vandecappelle
2015-09-15  3:59 ` [Buildroot] [PATCH 2/2] openssl: enable parallel build and installation Ryan Barnett
2015-09-15  6:01   ` Mike Frysinger
2015-09-15 16:50   ` Arnout Vandecappelle
2015-09-15 19:34     ` Ryan Barnett
  -- strict thread matches above, loose matches on Subject: below --
2015-05-16 19:04 [Buildroot] [PATCH 1/2] openssl: use git formatted patches Thomas Petazzoni
2015-07-20 14:07 ` Thomas Petazzoni
2015-07-21 13:05   ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F84B9F.8060908@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.