From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Sheng Yong <shengyong1@huawei.com>, <dedekind1@gmail.com>,
<richard.weinberger@gmail.com>
Cc: <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] UBIFS: print verbose message when rescanning a corrupted node
Date: Wed, 16 Sep 2015 13:45:10 +0800 [thread overview]
Message-ID: <55F901E6.6010408@cn.fujitsu.com> (raw)
In-Reply-To: <1442400499-22539-1-git-send-email-shengyong1@huawei.com>
On 09/16/2015 06:48 PM, Sheng Yong wrote:
> This is a trivial fix of showing verbose message when leb-recovery detects
> a corrupted node, which is not the last one in the LEB. Rescan expects to
> show more detail of the corrupted node.
>
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Looks good.
Reviewed-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> fs/ubifs/recovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index 62903b6..e18085b 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -805,7 +805,7 @@ struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
> corrupted_rescan:
> /* Re-scan the corrupted data with verbose messages */
> ubifs_err(c, "corruption %d", ret);
> - ubifs_scan_a_node(c, buf, len, lnum, offs, 1);
> + ubifs_scan_a_node(c, buf, len, lnum, offs, 0);
> corrupted:
> ubifs_scanned_corruption(c, lnum, offs, buf);
> err = -EUCLEAN;
>
prev parent reply other threads:[~2015-09-16 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 10:48 [PATCH] UBIFS: print verbose message when rescanning a corrupted node Sheng Yong
2015-09-16 5:45 ` Dongsheng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F901E6.6010408@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=shengyong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.