All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu-devl <qemu-devel@nongnu.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] nbd: wait all read/write requests finished when shutdowning nbd socket
Date: Wed, 16 Sep 2015 10:35:14 +0200	[thread overview]
Message-ID: <55F929C2.4080703@redhat.com> (raw)
In-Reply-To: <55F926E3.4010006@cn.fujitsu.com>



On 16/09/2015 10:22, Wen Congyang wrote:
>>> >>      if (exp->blk) {
>>> >> +        bdrv_drain(blk_bs(exp->blk));
>>> >>          blk_remove_aio_context_notifier(exp->blk, blk_aio_attached,
>>> >>                                          blk_aio_detach, exp);
>>> >>          blk_unref(exp->blk);
>> > 
>> > I think a better fix is to move the whole "if" to nbd_export_put.  In
>> > fact, nbd_export_close is wrong because exp can be freed by
>> > nbd_export_close's call to nbd_export_put.
> OK, I will fix it in the next version.

To be clear, the bug is pre-existing (commit 38b54b6, "nbd: use
BlockDriverState refcnt", 2013-08-23).

Paolo

      reply	other threads:[~2015-09-16  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  7:16 [Qemu-devel] [PATCH] nbd: wait all read/write requests finished when shutdowning nbd socket Wen Congyang
2015-09-16  8:17 ` Paolo Bonzini
2015-09-16  8:22   ` Wen Congyang
2015-09-16  8:35     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F929C2.4080703@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wency@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.