From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zc8ei-0008Hi-Sw for qemu-devel@nongnu.org; Wed, 16 Sep 2015 05:05:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zc8ef-0001WI-05 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 05:05:32 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:39991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zc8ee-0001Vw-KC for qemu-devel@nongnu.org; Wed, 16 Sep 2015 05:05:28 -0400 References: <1441708451-12699-1-git-send-email-alex.smith@imgtec.com> <20150916052740.GB12445@aurel32.net> From: Leon Alrae Message-ID: <55F930CF.9010107@imgtec.com> Date: Wed, 16 Sep 2015 10:05:19 +0100 MIME-Version: 1.0 In-Reply-To: <20150916052740.GB12445@aurel32.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Smith , qemu-devel@nongnu.org, Alex Smith On 16/09/15 06:27, Aurelien Jarno wrote: > Independently of your patch, I do wonder if we shouldn't change the > return type of cpu_mips_get_count to int32_t. With your patch, there > are now 2 calls to this functions, and both cast the value to int32_t. Yes, I think that will make more sense if the return type of cpu_mips_get_count() matches CP0_Count. Leon