From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZcAnh-0006HG-GZ
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 07:22:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZcAne-00045l-EF
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 07:22:57 -0400
Received: from [59.151.112.132] (port=32647 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZcAne-00045N-0G
	for qemu-devel@nongnu.org; Wed, 16 Sep 2015 07:22:54 -0400
Message-ID: <55F95106.8090908@cn.fujitsu.com>
Date: Wed, 16 Sep 2015 19:22:46 +0800
From: Yang Hongyang <yanghy@cn.fujitsu.com>
MIME-Version: 1.0
References: <1441783481-17698-1-git-send-email-yanghy@cn.fujitsu.com>
	<55F65685.7080504@cn.fujitsu.com> <55F659A4.7090705@redhat.com>
	<55F65CD6.1020009@cn.fujitsu.com> <55F93AF1.8030005@redhat.com>
In-Reply-To: <55F93AF1.8030005@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v10 00/10] Add a netfilter object and
 netbuffer filter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, thuth@redhat.com, zhang.zhanghailiang@huawei.com, stefanha@redhat.com, armbru@redhat.com



On 09/16/2015 05:48 PM, Jason Wang wrote:
>
>
> On 09/14/2015 01:36 PM, Yang Hongyang wrote:
>>
>>
>> On 09/14/2015 01:22 PM, Jason Wang wrote:
>>>
>>>
>>> On 09/14/2015 01:09 PM, Yang Hongyang wrote:
>>>> Hi Stefan,Jason,
>>>>
>>>> I've convert this series to base on QOM, and introducing NetQueue apis
>>>> instead of using Netqueue internals as Stefan suggested. Could you
>>>> please take a
>>>> look at it?
>>>
>>> Will go through this in next few days.
>>
>> Thanks a lot.
>
> Looks good to me overall. Just have small nitpicks, see individual
> replies for details. If you want to send V11, may be worth to consider
> them. (But not a requirement).

Thanks a lot for the review, will send a V11 address them and with multiqueue
support as additional patches together.

>
> Thanks
> .
>

-- 
Thanks,
Yang.