From: Ludger Dreier <Ludger.Dreier@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "env_eeprom: Assign default environment during board_init_f"
Date: Wed, 16 Sep 2015 13:46:34 +0200 [thread overview]
Message-ID: <55F9569A.4010401@keymile.com> (raw)
In-Reply-To: <20150915165437.GH26226@bill-the-cat>
Hi Tom,
Am 2015-09-15 18:54, schrieb Tom Rini:
> Was there perhaps some sort of init ordering issue in a board which
> did have EEPROM used as the backing store for env? I could see a
> case where perhaps (and Ludger, can you test this as well please?)
> the problem is that for env_eeprom env_init() needs to just default
> to the built-in (like it's basically doing today) and
> env_relocate_spec() needs to do the read, check which is valid, etc,
> etc, dance which it is _not_ doing today.
>
as I understand your idea, the code from both versions of env_init
(redundant env and non-redunant) which is framed by
"#ifdef ENV_IS_EMBEDDED" may potentially be moved to, or called by
env_relocate_spec. I think this could work. If this ok for you,
I can come up with a tested proposal. But this would need some days.
Ludger
next prev parent reply other threads:[~2015-09-16 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 9:35 [U-Boot] [PATCH] Revert "env_eeprom: Assign default environment during board_init_f" Ludger Dreier
2015-09-15 16:54 ` Tom Rini
2015-09-16 11:46 ` Ludger Dreier [this message]
2015-09-16 11:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F9569A.4010401@keymile.com \
--to=ludger.dreier@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.