Re: [meta-browser][PATCH 1/3] chromium: Allow to build in Debug mode.

[Carlos Alberto Lopez Perez <clopez@igalia.com>]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

On 15/09/15 19:00, Khem Raj wrote:
> On Tue, Sep 15, 2015 at 8:03 AM, Trevor Woerner <twoerner@gmail.com> wrote:
>> On 09/15/15 08:50, Carlos Alberto Lopez Perez wrote:
>>>   * Add also a patch that workarounds a build error when building
>>>     in Debug mode and using GCC. This patch has no effect when
>>>     building in Release mode because is guarded within ifdef(debug)
>>>     blocks.
>>>
>>> Signed-off-by: Carlos Alberto Lopez Perez <clopez@igalia.com>
>>> ---
>>>  recipes-browser/chromium/chromium.inc              |  4 ++-
>>>  .../fix-build-error-with-GCC-in-Debug-mode.patch   | 32 ++++++++++++++++++++++
>>>  recipes-browser/chromium/chromium_40.0.2214.91.bb  |  1 +
>>>  3 files changed, 36 insertions(+), 1 deletion(-)
>>>  create mode 100644 recipes-browser/chromium/chromium/chromium-40/fix-build-error-with-GCC-in-Debug-mode.patch
>>
>> Does the above patch need an upstream-status tag?
> 
> Its not must for meta-broweser, but its good since it adds
> information. We do not have any automatic tracking of patch status
> so if one mentions url for source of patch or any information on where
> patch's status can be asserted at later times is good.
> 

The patch itself includes in the comments at top the URL to the chromium
bugtracker where the issue was reported and the patch forwarded.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]