All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, houcheng@gmail.com,
	Andy Grover <agrover@redhat.com>,
	James Bottomley <jbottomley@parallels.com>,
	Douglas Gilbert <dgilbert@interlog.com>,
	Linux SCSI List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h
Date: Wed, 16 Sep 2015 16:15:46 +0200	[thread overview]
Message-ID: <55F97992.6050905@redhat.com> (raw)
In-Reply-To: <20150916133926.GA9658@lst.de>



On 16/09/2015 15:39, Christoph Hellwig wrote:
> Hi Paolo,
> 
> can you just move them to include/linux/ directly?

I'm trying to cater to the objections that were made to Andy's patch.
If you mean the non-UAPI headers, James wanted them to stay in scsi/; if
you mean the UAPI headers, Douglas complained about the flat structure
of include/linux/.

> Also scsi/scsi.h has some additional ioctl defintions that should be
> added to the UAPI scsi_ioctl.h.  Otherwise this looks ok to me.

I can do this, but I think they are obsoleted by SG_GET_SCSI_ID, except
for SCSI_IOCTL_GET_PCI which is horrible anyway. :)  The comment about
conflicts with CDROM ioctls is also interesting.  I can see why one
would want to keep them out of the new canonical place for SCSI ioctls.

Paolo

  reply	other threads:[~2015-09-16 14:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  9:21 [PATCH] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h Paolo Bonzini
2015-09-16 13:39 ` Christoph Hellwig
2015-09-16 14:15   ` Paolo Bonzini [this message]
2015-09-16 14:23     ` Christoph Hellwig
2015-09-16 14:31       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F97992.6050905@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agrover@redhat.com \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=houcheng@gmail.com \
    --cc=jbottomley@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.