From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Wed, 16 Sep 2015 18:16:50 +0100 Subject: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") In-Reply-To: <20150917011021.0460792d@xhacker> References: <20150917003202.498ff83c@xhacker> <20150917005908.111c00ca@xhacker> <20150917011021.0460792d@xhacker> Message-ID: <55F9A402.1060408@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16/09/15 18:10, Jisheng Zhang wrote: > Dear Thomas, > > On Thu, 17 Sep 2015 00:59:08 +0800 > Jisheng Zhang wrote: > >> On Wed, 16 Sep 2015 18:52:41 +0200 >> Thomas Gleixner wrote: >> >>> On Thu, 17 Sep 2015, Jisheng Zhang wrote: >>> >>>> Hi Marc, >>>> >>>> Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a >>>> guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one >>>> GIC, the secondary irq controller is Synopsys DW iCtl: >>>> drivers/irqchip/irq-dw-apb-ictl.c >>>> >>>> So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns >>>> false. The logic in cascading_gic_irq() doesn't take cascaded irq controller >>>> which is provided by non-gic controllers. >>> >>> I have a fix pending for this in >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq >>> >>> 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag >>> >>> Can you please give that a try? >> >> Sure, Will try and get back to you > > Good news! The regression is fixed, cascaded irq works again! > > Feel free to add > > Tested-by: Jisheng Zhang Ah, excellent. Probably a case of handler_data being reused... Thanks a lot for testing this! M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753048AbbIPRQy (ORCPT ); Wed, 16 Sep 2015 13:16:54 -0400 Received: from foss.arm.com ([217.140.101.70]:37662 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbbIPRQx (ORCPT ); Wed, 16 Sep 2015 13:16:53 -0400 Message-ID: <55F9A402.1060408@arm.com> Date: Wed, 16 Sep 2015 18:16:50 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Jisheng Zhang , Thomas Gleixner CC: jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") References: <20150917003202.498ff83c@xhacker> <20150917005908.111c00ca@xhacker> <20150917011021.0460792d@xhacker> In-Reply-To: <20150917011021.0460792d@xhacker> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/15 18:10, Jisheng Zhang wrote: > Dear Thomas, > > On Thu, 17 Sep 2015 00:59:08 +0800 > Jisheng Zhang wrote: > >> On Wed, 16 Sep 2015 18:52:41 +0200 >> Thomas Gleixner wrote: >> >>> On Thu, 17 Sep 2015, Jisheng Zhang wrote: >>> >>>> Hi Marc, >>>> >>>> Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a >>>> guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one >>>> GIC, the secondary irq controller is Synopsys DW iCtl: >>>> drivers/irqchip/irq-dw-apb-ictl.c >>>> >>>> So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns >>>> false. The logic in cascading_gic_irq() doesn't take cascaded irq controller >>>> which is provided by non-gic controllers. >>> >>> I have a fix pending for this in >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq >>> >>> 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag >>> >>> Can you please give that a try? >> >> Sure, Will try and get back to you > > Good news! The regression is fixed, cascaded irq works again! > > Feel free to add > > Tested-by: Jisheng Zhang Ah, excellent. Probably a case of handler_data being reused... Thanks a lot for testing this! M. -- Jazz is not dead. It just smells funny...