Re: [PATCH] xen/xsm: Shut up GCC 5.1.1 warnings.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 16/09/2015 18:12, Konrad Rzeszutek Wilk wrote:
> policydb.c: In function ‘user_read’:
> policydb.c:1443:26: error: ‘buf[2]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>          usrdatum->bounds = le32_to_cpu(buf[2]);
>                           ^
> cc1: all warnings being treated as errors
>
> Which makes no sense, as :
>  1). A couple of lines above it is being filled (buf[2]).
>  2). There are other instances of this which are not triggering this
>      failure.
>
> But GCC insists, and this patch stops the failures.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

A better bet would just be to initialise buf at declaration time, so
"__le32 buf[3] = { 0 };"

The reason this warning is firing is that C may not assume that
p->policyvers doesn't change between the next_entry() call and the
role->bounds assignment.  Pulling p->policyvers into a local variable
might also be sufficient.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel