From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcIqX-0002s3-Nn for qemu-devel@nongnu.org; Wed, 16 Sep 2015 15:58:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcIqU-0008GP-Ii for qemu-devel@nongnu.org; Wed, 16 Sep 2015 15:58:25 -0400 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=52617 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcIqU-0008G9-Ct for qemu-devel@nongnu.org; Wed, 16 Sep 2015 15:58:22 -0400 Message-ID: <55F9C9DA.9000507@weilnetz.de> Date: Wed, 16 Sep 2015 21:58:18 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1442406595-14296-1-git-send-email-pbonzini@redhat.com> <1442406595-14296-17-git-send-email-pbonzini@redhat.com> <55F9ABD8.1070003@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Paolo Bonzini , "qemu-devel@nongnu.org Developers" , Peter Crosthwaite Am 16.09.2015 um 21:14 schrieb Peter Crosthwaite: > On Wed, Sep 16, 2015 at 10:50 AM, Stefan Weil wrote: >> Am 16.09.2015 um 14:29 schrieb Paolo Bonzini: >>> From: Peter Crosthwaite >>> >>> This requires global visibility to common code. Move to tcg-common. >>> >>> Cc: Stefan Weil >>> Signed-off-by: Peter Crosthwaite >>> Message-Id: >>> Signed-off-by: Paolo Bonzini >>> --- >>> tcg/tcg-common.c | 4 ++++ >>> tci.c | 6 ------ >>> 2 files changed, 4 insertions(+), 6 deletions(-) >>> >> >> The original versions of patches 15 and 16 did not catch >> my attention because To / Cc did not include my name. >> >> Maybe a problem with the git configuration on the sender side? >> >=20 > Sorry. I have fixed that issue (sneaky suppress-cc on my send-email scr= ipt). >=20 > Is the patch ok? >=20 > Regards, > Peter It looks fine. I'd keep the comment which you removed in tci.c and move it to the code location where tci_tb_ptr is used. But that can be done in a later patch, no need to disturb Paolo's pull request. With your QEMU multi-arch modification and some smaller additional patches it might become possible to build a single QEMU executable which supports both interpreted and normal TCG, so the TCG interpreter could be available by default. Users would need a command line option like --enable-tci to enable it. Regards Stefan