All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Robert Baldyga <r.baldyga@samsung.com>, gregkh@linuxfoundation.org
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function
Date: Thu, 17 Sep 2015 16:35:18 +0900	[thread overview]
Message-ID: <55FA6D36.5090600@samsung.com> (raw)
In-Reply-To: <1442321340-28167-4-git-send-email-r.baldyga@samsung.com>

On 15.09.2015 21:48, Robert Baldyga wrote:
> This patch introduces s3c24xx_serial_rx_drain_fifo() which reads data
> from RX FIFO and writes it to tty buffer. It also checks for special
> conditions (such as 'break') and handles it. This function has been
> separated from s3c24xx_serial_rx_chars_pio() as it contains code which
> can be used also in DMA mode.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
>  drivers/tty/serial/samsung.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)

Thanks for splitting the code. It looks good but I don't feel
experienced enough in the driver internals to give a review tag. :)

Best regards,
Krzysztof

  parent reply	other threads:[~2015-09-17  7:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15 12:48 [PATCH v3 0/4] serial: samsung: Fix UART status handling and other fixes Robert Baldyga
2015-09-15 12:48 ` [PATCH v3 1/4] serial: samsung: remove unused 'irq' parameter Robert Baldyga
2015-09-15 12:48 ` [PATCH v3 2/4] serial: samsung: remove unneded 'ignore_char' label Robert Baldyga
2015-09-15 12:48 ` [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function Robert Baldyga
2015-09-17  7:27   ` Krzysztof Kozlowski
2015-09-17  7:35   ` Krzysztof Kozlowski [this message]
2015-09-15 12:49 ` [PATCH v3 4/4] serial: samsung: Fix UART status handling in DMA mode Robert Baldyga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FA6D36.5090600@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=r.baldyga@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.