From: Richard Alpe <richard.alpe@ericsson.com>
To: David Ahern <dsa@cumulusnetworks.com>, <netdev@vger.kernel.org>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
<sergey.senozhatsky.work@gmail.com>, <festevam@gmail.com>
Subject: Re: [PATCH net-next v2] net: Initialize table in fib result
Date: Thu, 17 Sep 2015 09:45:16 +0200 [thread overview]
Message-ID: <55FA6F8C.90808@ericsson.com> (raw)
In-Reply-To: <55F996AC.1090305@cumulusnetworks.com>
On 2015-09-16 18:19, Nikolay Aleksandrov wrote:
> The root cause is use of res.table uninitialized.
>>
>> Thanks to Nikolay for noticing the uninitialized use amongst the maze of
>> gotos.
>>
>> As Nikolay pointed out the second initialization is not required to fix
>> the oops, but rather to fix a related problem where a valid lookup should
>> be invalidated before creating the rth entry.
>>
>> Fixes: b7503e0cdb5d ("net: Add FIB table id to rtable")
>> Reported-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
>> Reported-by: Richard Alpe <richard.alpe@ericsson.com>
Works for me as well. Thanks!
(Tested-by: Richard Alpe <richard.alpe@ericsson.com>)
Regards
Richard
next prev parent reply other threads:[~2015-09-17 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 16:16 [PATCH net-next v2] net: Initialize table in fib result David Ahern
2015-09-16 16:19 ` Nikolay Aleksandrov
2015-09-17 7:45 ` Richard Alpe [this message]
2015-09-16 23:58 ` Florian Fainelli
2015-09-17 0:00 ` Sergey Senozhatsky
2015-09-18 4:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FA6F8C.90808@ericsson.com \
--to=richard.alpe@ericsson.com \
--cc=dsa@cumulusnetworks.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.