From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38875)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@odin.com>) id 1ZcV4a-0005pr-Je
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 05:01:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vsementsov@odin.com>) id 1ZcV4W-000166-5v
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 05:01:44 -0400
Received: from relay.parallels.com ([195.214.232.42]:48085)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@odin.com>) id 1ZcV4V-00013u-T8
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 05:01:40 -0400
Message-ID: <55FA8167.5040809@virtuozzo.com>
Date: Thu, 17 Sep 2015 12:01:27 +0300
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
MIME-Version: 1.0
References: <1442333283-13119-1-git-send-email-marcandre.lureau@redhat.com>
	<1442333283-13119-38-git-send-email-marcandre.lureau@redhat.com>
In-Reply-To: <1442333283-13119-38-git-send-email-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 37/46] contrib: remove unnecessary
	strdup()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com

On 15.09.2015 19:07, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> getopt() optarg points to argv memory, no need to dup those values,
> fixes small leaks detected by clang-analyzer.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   contrib/ivshmem-client/main.c | 2 +-
>   contrib/ivshmem-server/main.c | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c
> index 5d85ae7..bd7cbfc 100644
> --- a/contrib/ivshmem-client/main.c
> +++ b/contrib/ivshmem-client/main.c
> @@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc, char *argv[])
>               break;
>   
>           case 'S': /* unix_sock_path */
> -            args->unix_sock_path = strdup(optarg);
> +            args->unix_sock_path = optarg;
>               break;
>   
>           default:
> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
> index cd8d9ed..71e87ea 100644
> --- a/contrib/ivshmem-server/main.c
> +++ b/contrib/ivshmem-server/main.c
> @@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int argc, char *argv[])
>               break;
>   
>           case 'p': /* pid_file */
> -            args->pid_file = strdup(optarg);
> +            args->pid_file = optarg;
>               break;
>   
>           case 'S': /* unix_socket_path */
> -            args->unix_socket_path = strdup(optarg);
> +            args->unix_socket_path = optarg;
>               break;
>   
>           case 'm': /* shm_path */
> -            args->shm_path = strdup(optarg);
> +            args->shm_path = optarg;
>               break;
>   
>           case 'l': /* shm_size */

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

-- 
Best regards,
Vladimir
* now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.