From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.windriver.com ([147.11.1.11]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZcVYw-0008N8-D2 for kexec@lists.infradead.org; Thu, 17 Sep 2015 09:33:06 +0000 Message-ID: <55FA88BD.3050303@windriver.com> Date: Thu, 17 Sep 2015 17:32:45 +0800 From: yjin MIME-Version: 1.0 Subject: Re: [PATCH] vmcore: replace Elf64_Ehdr/Elf32_Ehdr with elfhdr References: <1442372321-16334-1-git-send-email-yanjiang.jin@windriver.com> <1442372321-16334-2-git-send-email-yanjiang.jin@windriver.com> <20150916103917.GA32189@dhcp-128-25.nay.redhat.com> In-Reply-To: <20150916103917.GA32189@dhcp-128-25.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Minfei Huang Cc: kexec@lists.infradead.org, akpm@linux-foundation.org, jinyanjiang@gmail.com, linux-kernel@vger.kernel.org, chaowang@redhat.com Ck9uIDIwMTXlubQwOeaciDE25pelIDE4OjM5LCBNaW5mZWkgSHVhbmcgd3JvdGU6Cj4gT24gMDkv MTYvMTUgYXQgMTA6NThhbSwgeWFuamlhbmcuamluQHdpbmRyaXZlci5jb20gd3JvdGU6Cj4+IEZy b206IFlhbmppYW5nIEppbiA8eWFuamlhbmcuamluQHdpbmRyaXZlci5jb20+Cj4+Cj4+IEZ1bmN0 aW9uIHBhcnNlX2NyYXNoX2VsZl9oZWFkZXJzKCkgcmVhZHMgZV9pZGVudFtFSV9DTEFTU10gdGhl biBkZWNpZGVzIHRvCj4+IGNhbGwgcGFyc2VfY3Jhc2hfZWxmNjRfaGVhZGVycygpIG9yIHBhcnNl X2NyYXNoX2VsZjMyX2hlYWRlcnMoKS4KPj4gQnV0IHRoaXMgaGFwcGVucyBpbiBydW4gdGltZSwg bm90IGNvbXBpbGUgdGltZS4gU28gY29tcGlsZXIgd2lsbCByZXBvcnQKPj4gdGhlIGJlbG93IHdh cm5pbmc6Cj4+Cj4+IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBpbmNsdWRlL2xpbnV4L2VsZi5oOjQ6 MCwKPj4gICAgICAgICAgICAgICAgICAgZnJvbSBmcy9wcm9jL3ZtY29yZS5jOjEzOgo+PiBmcy9w cm9jL3ZtY29yZS5jOiBJbiBmdW5jdGlvbiAncGFyc2VfY3Jhc2hfZWxmMzJfaGVhZGVycyc6Cj4+ IGFyY2gvbWlwcy9pbmNsdWRlL2FzbS9lbGYuaDoyNTg6MjM6IHdhcm5pbmc6IGluaXRpYWxpemF0 aW8KPj4gbiBmcm9tIGluY29tcGF0aWJsZSBwb2ludGVyIHR5cGUKPj4gICAgc3RydWN0IGVsZmhk ciAqX19oID0gKGhkcik7ICAgICBcCj4+ICAgICAgICAgICAgICAgICAgICAgICAgIF4KPiBIb3cg YWJvdXQgY29udmVydGluZyB0aGUgaGRyIHRvIHR5cGUgZWxmaGRyIGluIGFib3ZlIHNlbnRlbmNl LCBsaWtlCj4gZm9sbG93aW5nLgo+Cj4gc3RydWN0IGVsZmhkciAqX19oID0gKHN0cnVjdCBlbGZo ZHIgKikoaGRyKTsKClllcywgdGhpcyBpcyBhIHJlcGxhY2VtZW50LCBhbmQgaXQgc2VlbXMgbW9y ZSBzYWZlIGJlY2F1c2UgaXQganVzdCAKYWZmZWN0cyBNSVBTIGFyY2guCkJ1dCBJIGFsc28gY2Fu J3Qgc2VlIGFueSBvYnZpb3VzIGltcGFjdCBpZiBtb2RpZnlpbmcgY29tbW9uIHZtY29yZS5jOi0p CkFueXdheSwgaWYgeW91IHN0aWNrIHRvIHlvdXIgb3BpbmlvbiwgSSBjYW4gc2VuZCBhIFYyIHBh dGNoIHRvIHVwZGF0ZSAKbWlwcycgZWxmLmggcmF0aGVyIHRoYW4gdm1jb3JlLmMuCgpUaGFua3Mh CllhbmppYW5nCj4KPiBUaGFua3MKPiBNaW5mZWkKPgo+PiBmcy9wcm9jL3ZtY29yZS5jOjEwNzE6 NDogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvICdlbGZfCj4+IGNoZWNrX2FyY2gnCj4+ICAg ICAhZWxmX2NoZWNrX2FyY2goJmVoZHIpIHx8Cj4+ICAgICAgXgo+Pgo+PiBTaWduZWQtb2ZmLWJ5 OiBZYW5qaWFuZyBKaW4gPHlhbmppYW5nLmppbkB3aW5kcml2ZXIuY29tPgo+PiAtLS0KPj4gICBm cy9wcm9jL3ZtY29yZS5jIHwgNCArKy0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2ZzL3Byb2Mvdm1jb3JlLmMg Yi9mcy9wcm9jL3ZtY29yZS5jCj4+IGluZGV4IDRlNjEzODguLjU3NmJiMjYgMTAwNjQ0Cj4+IC0t LSBhL2ZzL3Byb2Mvdm1jb3JlLmMKPj4gKysrIGIvZnMvcHJvYy92bWNvcmUuYwo+PiBAQCAtOTk5 LDcgKzk5OSw3IEBAIHN0YXRpYyB2b2lkIGZyZWVfZWxmY29yZWJ1Zih2b2lkKQo+PiAgIHN0YXRp YyBpbnQgX19pbml0IHBhcnNlX2NyYXNoX2VsZjY0X2hlYWRlcnModm9pZCkKPj4gICB7Cj4+ICAg CWludCByYz0wOwo+PiAtCUVsZjY0X0VoZHIgZWhkcjsKPj4gKwlzdHJ1Y3QgZWxmaGRyIGVoZHI7 Cj4+ICAgCXU2NCBhZGRyOwo+PiAgIAo+PiAgIAlhZGRyID0gZWxmY29yZWhkcl9hZGRyOwo+PiBA QCAtMTA1NSw3ICsxMDU1LDcgQEAgZmFpbDoKPj4gICBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9j cmFzaF9lbGYzMl9oZWFkZXJzKHZvaWQpCj4+ICAgewo+PiAgIAlpbnQgcmM9MDsKPj4gLQlFbGYz Ml9FaGRyIGVoZHI7Cj4+ICsJc3RydWN0IGVsZmhkciBlaGRyOwo+PiAgIAl1NjQgYWRkcjsKPj4g ICAKPj4gICAJYWRkciA9IGVsZmNvcmVoZHJfYWRkcjsKCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754578AbbIQJdK (ORCPT ); Thu, 17 Sep 2015 05:33:10 -0400 Received: from mail.windriver.com ([147.11.1.11]:49608 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbbIQJdI (ORCPT ); Thu, 17 Sep 2015 05:33:08 -0400 Message-ID: <55FA88BD.3050303@windriver.com> Date: Thu, 17 Sep 2015 17:32:45 +0800 From: yjin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Minfei Huang CC: , , , , Subject: Re: [PATCH] vmcore: replace Elf64_Ehdr/Elf32_Ehdr with elfhdr References: <1442372321-16334-1-git-send-email-yanjiang.jin@windriver.com> <1442372321-16334-2-git-send-email-yanjiang.jin@windriver.com> <20150916103917.GA32189@dhcp-128-25.nay.redhat.com> In-Reply-To: <20150916103917.GA32189@dhcp-128-25.nay.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年09月16日 18:39, Minfei Huang wrote: > On 09/16/15 at 10:58am, yanjiang.jin@windriver.com wrote: >> From: Yanjiang Jin >> >> Function parse_crash_elf_headers() reads e_ident[EI_CLASS] then decides to >> call parse_crash_elf64_headers() or parse_crash_elf32_headers(). >> But this happens in run time, not compile time. So compiler will report >> the below warning: >> >> In file included from include/linux/elf.h:4:0, >> from fs/proc/vmcore.c:13: >> fs/proc/vmcore.c: In function 'parse_crash_elf32_headers': >> arch/mips/include/asm/elf.h:258:23: warning: initializatio >> n from incompatible pointer type >> struct elfhdr *__h = (hdr); \ >> ^ > How about converting the hdr to type elfhdr in above sentence, like > following. > > struct elfhdr *__h = (struct elfhdr *)(hdr); Yes, this is a replacement, and it seems more safe because it just affects MIPS arch. But I also can't see any obvious impact if modifying common vmcore.c:-) Anyway, if you stick to your opinion, I can send a V2 patch to update mips' elf.h rather than vmcore.c. Thanks! Yanjiang > > Thanks > Minfei > >> fs/proc/vmcore.c:1071:4: note: in expansion of macro 'elf_ >> check_arch' >> !elf_check_arch(&ehdr) || >> ^ >> >> Signed-off-by: Yanjiang Jin >> --- >> fs/proc/vmcore.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c >> index 4e61388..576bb26 100644 >> --- a/fs/proc/vmcore.c >> +++ b/fs/proc/vmcore.c >> @@ -999,7 +999,7 @@ static void free_elfcorebuf(void) >> static int __init parse_crash_elf64_headers(void) >> { >> int rc=0; >> - Elf64_Ehdr ehdr; >> + struct elfhdr ehdr; >> u64 addr; >> >> addr = elfcorehdr_addr; >> @@ -1055,7 +1055,7 @@ fail: >> static int __init parse_crash_elf32_headers(void) >> { >> int rc=0; >> - Elf32_Ehdr ehdr; >> + struct elfhdr ehdr; >> u64 addr; >> >> addr = elfcorehdr_addr;