From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] MAINTAINERS: Document maintainers for xen/common/ Date: Thu, 17 Sep 2015 13:04:02 +0100 Message-ID: <55FAAC32.3040806@citrix.com> References: <1442490839-23962-1-git-send-email-ian.jackson@eu.citrix.com> <55FAAB19.4080405@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55FAAB19.4080405@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Ian Jackson , xen-devel@lists.xensource.com Cc: Tim Deegan , Keir Fraser , Ian Campbell , Jan Beulich , David Vrabel List-Id: xen-devel@lists.xenproject.org On 17/09/15 12:59, Andrew Cooper wrote: > On 17/09/15 12:53, Ian Jackson wrote: >> This is a copy of the `THE REST' entry but with my own entry removed >> (as I do not normally review hypervisor patches) and Andrew Cooper's >> added (which seems appropriate given his status as x86 hypervisor >> maintainer). >> >> The effect is that patches touching xen/common/ will no longer be CC'd >> to me; but also that Ian C, Andrew, Jan, Keir and Tim will get _all_ >> patches touching xen/common/, not just ones which match one of their >> existing more specific entries. >> >> Signed-off-by: Ian Jackson >> CC: Ian Campbell >> CC: Jan Beulich >> CC: Keir Fraser >> CC: Tim Deegan >> CC: Julien Grall >> CC: David Vrabel >> CC: Andrew Cooper >> >> --- >> v2: A completely different approach following discussion with Ian C. >> --- >> MAINTAINERS | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index a6bece6..e35c1e9 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -404,6 +404,16 @@ F: xen/include/xsm/ >> F: xen/xsm/ >> F: docs/misc/xsm-flask.txt >> >> +HYPERVISOR CORE >> +M: Jan Beulich >> +M: Tim Deegan >> +M: Keir Fraser >> +M: Ian Campbell >> +M: Andrew Cooper >> +L: xen-devel@lists.xen.org >> +S: Supported >> +F: xen/common/ > > I am happy with the change in principle, but it should cover xen/ rather > than xen/common/ to also include otherwise unqualified items in > xen/drivers/. The first version of this patch was covering xen/. But the downside was to CC all the "REST OF THE HYPERVISOR" group to any changes under xen/. I.e you would be CCed on ARM changes for instance. See http://lists.xen.org/archives/html/xen-devel/2015-09/msg02171.html I know some maintainers which will complaining very quickly on the ML and ask the contributors to use correctly scripts/get_maintainers.pl. But the scrips doesn't do correctly his job for Xen... Regards, -- Julien Grall