From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZcYVn-0002SB-QQ
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 08:42:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZcYVj-0000mp-5U
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 08:42:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36926)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZcYVi-0000mh-VD
	for qemu-devel@nongnu.org; Thu, 17 Sep 2015 08:41:59 -0400
References: <1442061415-17430-1-git-send-email-knut.omang@oracle.com>
	<1442061415-17430-2-git-send-email-knut.omang@oracle.com>
	<55FA9FFA.2020901@gmail.com> <1442491936.2488.135.camel@oracle.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <55FAB511.1030901@redhat.com>
Date: Thu, 17 Sep 2015 15:41:53 +0300
MIME-Version: 1.0
In-Reply-To: <1442491936.2488.135.camel@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 1/3] pci: Make use of the devfn property
 when registering new devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Knut Omang <knut.omang@oracle.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Richard W.M. Jones" <rjones@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@web.de>, Paolo Bonzini <pbonzini@redhat.com>, Dotan Barak <dotanba@gmail.com>, Richard Henderson <rth@twiddle.net>

On 09/17/2015 03:12 PM, Knut Omang wrote:
> On Thu, 2015-09-17 at 14:11 +0300, Marcel Apfelbaum wrote:
>> On 09/12/2015 03:36 PM, Knut Omang wrote:
>>> Without this, the devfn argument to pci_create_*()
>>> does not affect the assigned devfn.
>>>
>>> Needed to support (VF_STRIDE,VF_OFFSET) values other than (1,1)
>>> for SR/IOV.
>>>
>>> Signed-off-by: Knut Omang <knut.omang@oracle.com>
>>> ---
>>>    hw/pci/pci.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
>>> index ccea628..a5cc015 100644
>>> --- a/hw/pci/pci.c
>>> +++ b/hw/pci/pci.c
>>> @@ -1840,7 +1840,7 @@ static void pci_qdev_realize(DeviceState
>>> *qdev, Error **errp)
>>>        bus = PCI_BUS(qdev_get_parent_bus(qdev));
>>>        pci_dev = do_pci_register_device(pci_dev, bus,
>>>
>>>   object_get_typename(OBJECT(qdev)),
>>> -                                     pci_dev->devfn, errp);
>>> +
>>>   object_property_get_int(OBJECT(qdev), "addr", NULL), errp);
>> Hi,
>>
>> I don't get this, using object_property_get_int on "addr" should
>> return the value of pci_dev->devfn,
>> can you please tell what exactly is not working?
>
> The problem is that at that point pci_dev->devfn has not been set yet -
> have commented on this before somewhere..
>

But "addr" property has the right value? Is indeed strange because it should
get the value from pci_dev->devfn.

Don't get me wrong, this patch is OK.
I just want to understand if we have a hidden bug somewhere.

Anyway,
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

> Knut
>
>> Thanks,
>> Marcel
>>
>>
>>
>>>        if (pci_dev == NULL)
>>>            return;
>>>
>>>
>>