From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@canonical.com>, linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Ming Lin <ming.l@ssi.samsung.com>, Dongsu Park <dpark@posteo.net>
Subject: Re: [PATCH] block: blk-merge: fast-clone bio when splitting rw bios
Date: Thu, 17 Sep 2015 09:19:11 -0600 [thread overview]
Message-ID: <55FAD9EF.5040100@kernel.dk> (raw)
In-Reply-To: <1442502807-24377-1-git-send-email-ming.lei@canonical.com>
On 09/17/2015 09:13 AM, Ming Lei wrote:
> biovecs has become immutable since v3.13, so it isn't necessary
> to allocate biovecs for the new cloned bios, then we can save
> one extra biovecs allocation/copy, and the allocation is often
> not fixed-length and a bit more expensive.
>
> For example, if the 'max_sectors_kb' of null blk's queue is set
> as 16(32 sectors) via sysfs just for making more splits, this patch
> can increase throught about ~70% in the sequential read test over
> null_blk(direct io, bs: 1M).
I'd be curious how this compares to before we did the splitting, not
exceeding the limits through bio_add_page() instead?
--
Jens Axboe
next prev parent reply other threads:[~2015-09-17 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 15:13 [PATCH] block: blk-merge: fast-clone bio when splitting rw bios Ming Lei
2015-09-17 15:19 ` Jens Axboe [this message]
2015-09-17 15:50 ` Ming Lei
2015-09-17 15:55 ` Jens Axboe
2015-09-17 16:01 ` Jens Axboe
2015-09-17 16:08 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAD9EF.5040100@kernel.dk \
--to=axboe@kernel.dk \
--cc=dpark@posteo.net \
--cc=hch@infradead.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.l@ssi.samsung.com \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.